From patchwork Mon Feb 13 07:31:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kbuild test robot X-Patchwork-Id: 727130 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vMHLR6rmYz9s7c for ; Mon, 13 Feb 2017 18:31:59 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751883AbdBMHb7 (ORCPT ); Mon, 13 Feb 2017 02:31:59 -0500 Received: from mga01.intel.com ([192.55.52.88]:48407 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbdBMHb6 (ORCPT ); Mon, 13 Feb 2017 02:31:58 -0500 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2017 23:31:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,155,1484035200"; d="scan'208";a="224566457" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by fmsmga004.fm.intel.com with ESMTP; 12 Feb 2017 23:31:54 -0800 Received: from kbuild by bee with local (Exim 4.84_2) (envelope-from ) id 1cdB9F-000Mpc-Le; Mon, 13 Feb 2017 15:34:09 +0800 Date: Mon, 13 Feb 2017 15:31:20 +0800 From: kbuild test robot To: Abutalib Aghayev Cc: kbuild-all@01.org, linux-ext4@vger.kernel.org, Theodore Ts'o Subject: [PATCH] fix ifnullfree.cocci warnings Message-ID: <20170213073119.GA17037@lkp-nex06.lkp.intel.com> References: <201702131515.Cca34rb0%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201702131515.Cca34rb0%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org fs/jbd2/jmap.c:19:2-20: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Abutalib Aghayev Signed-off-by: Fengguang Wu --- jmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/jbd2/jmap.c +++ b/fs/jbd2/jmap.c @@ -15,8 +15,7 @@ int jbd2_journal_init_jmap_cache(void) void jbd2_journal_destroy_jmap_cache(void) { - if (jbd2_jmap_cache) - kmem_cache_destroy(jbd2_jmap_cache); + kmem_cache_destroy(jbd2_jmap_cache); jbd2_jmap_cache = NULL; }