| Message ID | 20160317004847.GG23593@thunk.org |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Mar 16, 2016 at 08:48:47PM -0400, Theodore Ts'o wrote: > On Wed, Mar 16, 2016 at 03:49:31PM -0600, Andreas Dilger wrote: > > > > At one time I thought Dave was going to patch xfs_quota to try the quota > > ioctls for "foreign" filesystems like ext4 that supported them, but I'm > > not sure if that patch was landed, nor whether it has been released. > > > > On the opposite front, Jan was updating the generic quota tools to support > > the XFS ioctls that project quota is using? > > It's quite possible I'm missing something, but it doesn't look like > either has landed. I've hacked xfs_quota (not anything that I would > want to submit for merging) I posted a patch to do it, but I haven't had a chance to fix the problems Eric noticed because other stuff happened. You're welcome to fix it up and repost it: http://oss.sgi.com/archives/xfs/2016-02/msg00109.html Cheers, Dave.
On Wed 16-03-16 20:48:47, Ted Tso wrote: > On Wed, Mar 16, 2016 at 03:49:31PM -0600, Andreas Dilger wrote: > > > > At one time I thought Dave was going to patch xfs_quota to try the quota > > ioctls for "foreign" filesystems like ext4 that supported them, but I'm > > not sure if that patch was landed, nor whether it has been released. > > > > On the opposite front, Jan was updating the generic quota tools to support > > the XFS ioctls that project quota is using? > > It's quite possible I'm missing something, but it doesn't look like > either has landed. I've hacked xfs_quota (not anything that I would > want to submit for merging) so I can report usage project quota stats, > and to be able to set hard and soft limits. But I was trying to > figure out what we should be telling users who wanted to use Project > Quota, but I'm pretty sure "pull down xfsprogs sources, and apply this > hacky patch[1], and then when you use the tooll ignore a whole bunch > of spurious warnings" is the right way to go. :-) > > I am also curious how Li Xi was testing the patches he sent me. As Li Xi mentioned, he has a patch for quota-tools which implements the project quota support but it needs some cleanup (you can check my reply to email "[PATCH] Add project quota support" - it didn't go to any list but you were CCed). Li Xi, do you have any idea when you can get to it? Honza
diff --git a/libxcmd/paths.c b/libxcmd/paths.c index 5c65737..6c69a35 100644 --- a/libxcmd/paths.c +++ b/libxcmd/paths.c @@ -301,8 +301,8 @@ fs_table_initialise_mounts( return errno; while ((mnt = getmntent(mtp)) != NULL) { - if (strcmp(mnt->mnt_type, "xfs") != 0) - continue; +// if (strcmp(mnt->mnt_type, "xfs") != 0) +// continue; if (!realpath(mnt->mnt_dir, rmnt_dir)) continue; if (!realpath(mnt->mnt_fsname, rmnt_fsname))