From patchwork Mon Mar 7 03:43:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theodore Ts'o X-Patchwork-Id: 592762 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4B076140C79 for ; Mon, 7 Mar 2016 14:44:06 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=thunk.org header.i=@thunk.org header.b=xh0wWcnp; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbcCGDng (ORCPT ); Sun, 6 Mar 2016 22:43:36 -0500 Received: from imap.thunk.org ([74.207.234.97]:38754 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbcCGDnf (ORCPT ); Sun, 6 Mar 2016 22:43:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=ErI0jqO5LGzyNufCV0srpatboPuu7HLLJmQip8wPpao=; b=xh0wWcnpKDYpiOKglmcNxdeoWaW/cJ5vE1EbIcd2nA4p7RCUWL8up4a3mSOImquUqJ8dBlG2YIp3tROG0lc0bS+GQ/liaIK3+Jsv5OC4ix8BqkUyFpS4Xypsmcb8V6VCd2/zyjnzBH5PJE6tLiogSEH1RwBVvMVKps1yaI3yfvo=; Received: from root (helo=closure.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.84) (envelope-from ) id 1acm4y-0004rT-Ds; Mon, 07 Mar 2016 03:43:32 +0000 Received: by closure.thunk.org (Postfix, from userid 15806) id 909E58202C4; Sun, 6 Mar 2016 22:43:31 -0500 (EST) Date: Sun, 6 Mar 2016 22:43:31 -0500 From: Theodore Ts'o To: Andreas Dilger Cc: linux-ext4@vger.kernel.org, David Turner Subject: Re: [PATCH] e2fsck: Correct ext4 dates generated by old kernels Message-ID: <20160307034331.GI30238@thunk.org> References: <1455825476-36773-1-git-send-email-adilger@dilger.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1455825476-36773-1-git-send-email-adilger@dilger.ca> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Feb 18, 2016 at 12:57:56PM -0700, Andreas Dilger wrote: > From: David Turner > > Older kernels on 64-bit machines would incorrectly encode pre-1970 > ext4 dates as post-2311 dates. Detect and correct this (assuming the > current date is before 2242). > > Includes tests for this, as well as changes to debugfs to correctly > set crtimes. > > Signed-off-by: David Turner > > - ext2_fs.h: declare EXT4_EPOCH_BITS/EXT4_EPOCH_MASK like the kernel > instead of in a separate header in an unusual location > - problem.h: move PR_1_EA_TIME_OUT_OF_RANGE to avoid master conflict > - problem.c: fix PR_1_EA_TIME_OUT_OF_RANGE PR_*_OK flag usage > - f_pre_1970_date_encoding/script: run debugfs less often, > use $MKE2FS instead of mkfs.ext4, fit within 80 columns > > Signed-off-by: Andreas Dilger This patch is reporting test failures for the new f_pre_1970_date_encoding. Can you please take a look? Thanks, - Ted --- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- /usr/projects/e2fsprogs/e2fsprogs/tests/f_pre_1970_date_encoding/expect 2016-03-07 03:17:46.268647450 +0000 +++ f_pre_1970_date_encoding.timestamps.log 2016-03-07 03:20:52.067405831 +0000 @@ -1,45 +1,45 @@ times for year-1909 = - ctime: 0x8e475440:00000003 - atime: 0x8e475440:00000003 - mtime: 0x8e475440:00000003 -crtime: 0x8e475440:00000003 + ctime: 0x71b8abc0:00000003 + atime: 0x71b8abc0:00000003 + mtime: 0x71b8abc0:00000003 +crtime: 0x71b8abc0:00000003 times for year-1979 = - ctime: 0x11db6940:00000000 - atime: 0x11db6940:00000000 - mtime: 0x11db6940:00000000 -crtime: 0x11db6940:00000000 + ctime: 0x05efa740:00000000 + atime: 0x05efa740:00000000 + mtime: 0x05efa740:00000000 +crtime: 0x05efa740:00000000 times for year-2039 = - ctime: 0x82a37b40:00000001 - atime: 0x82a37b40:00000001 - mtime: 0x82a37b40:00000001 -crtime: 0x82a37b40:00000001 + ctime: 0x0b6de740:00000001 + atime: 0x0b6de740:00000001 + mtime: 0x0b6de740:00000001 +crtime: 0x0b6de740:00000001 times for year-2139 = - ctime: 0x3e9b9940:00000001 - atime: 0x3e9b9940:00000001 - mtime: 0x3e9b9940:00000001 -crtime: 0x3e9b9940:00000001 + ctime: 0x1495a740:00000001 + atime: 0x1495a740:00000001 + mtime: 0x1495a740:00000001 +crtime: 0x1495a740:00000001 times for year-1909 = - ctime: 0x8e475440:00000000 - atime: 0x8e475440:00000000 - mtime: 0x8e475440:00000000 -crtime: 0x8e475440:00000000 + ctime: 0x71b8abc0:00000003 + atime: 0x71b8abc0:00000003 + mtime: 0x71b8abc0:00000003 +crtime: 0x71b8abc0:00000003 times for year-1979 = - ctime: 0x11db6940:00000000 - atime: 0x11db6940:00000000 - mtime: 0x11db6940:00000000 -crtime: 0x11db6940:00000000 + ctime: 0x05efa740:00000000 + atime: 0x05efa740:00000000 + mtime: 0x05efa740:00000000 +crtime: 0x05efa740:00000000 times for year-2039 = - ctime: 0x82a37b40:00000001 - atime: 0x82a37b40:00000001 - mtime: 0x82a37b40:00000001 -crtime: 0x82a37b40:00000001 + ctime: 0x0b6de740:00000001 + atime: 0x0b6de740:00000001 + mtime: 0x0b6de740:00000001 +crtime: 0x0b6de740:00000001 times for year-2139 = - ctime: 0x3e9b9940:00000001 - atime: 0x3e9b9940:00000001 - mtime: 0x3e9b9940:00000001 -crtime: 0x3e9b9940:00000001 + ctime: 0x1495a740:00000001 + atime: 0x1495a740:00000001 + mtime: 0x1495a740:00000001 +crtime: 0x1495a740:00000001 times for year-1909 = - ctime: 0x8e475440:00000003 - atime: 0x8e475440:00000003 - mtime: 0x8e475440:00000003 -crtime: 0x8e475440:00000003 + ctime: 0x71b8abc0:00000003 + atime: 0x71b8abc0:00000003 + mtime: 0x71b8abc0:00000003 +crtime: 0x71b8abc0:00000003