| Message ID | 20141107215341.883.6602.stgit@birch.djwong.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, Nov 07, 2014 at 01:53:41PM -0800, Darrick J. Wong wrote: > resize2fs tries to infer the RAID stride by observing differences between the > locations of adjacent block groups' block and inode bitmaps within the block > group. If the two block groups being compared belong to different flexbgs, > however, it'll be fooled by the large offset into thinking that the FS has an > abnormally large RAID stride. > > Therefore, teach it not to get confused by crossing a flexbg. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > Reported-by: TR Reardon <thomas_reardon@hotmail.com> Applied, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/resize/main.c b/resize/main.c index 983d8c2..e017792 100644 --- a/resize/main.c +++ b/resize/main.c @@ -105,6 +105,7 @@ static void determine_fs_stride(ext2_filsys fs) unsigned long long sum; unsigned int has_sb, prev_has_sb = 0, num; int i_stride, b_stride; + int flexbg_size = 1 << fs->super->s_log_groups_per_flex; if (fs->stride) return; @@ -120,7 +121,8 @@ static void determine_fs_stride(ext2_filsys fs) ext2fs_inode_bitmap_loc(fs, group - 1) - fs->super->s_blocks_per_group; if (b_stride != i_stride || - b_stride < 0) + b_stride < 0 || + (flexbg_size > 1 && (group % flexbg_size == 0))) goto next; /* printf("group %d has stride %d\n", group, b_stride); */
resize2fs tries to infer the RAID stride by observing differences between the locations of adjacent block groups' block and inode bitmaps within the block group. If the two block groups being compared belong to different flexbgs, however, it'll be fooled by the large offset into thinking that the FS has an abnormally large RAID stride. Therefore, teach it not to get confused by crossing a flexbg. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reported-by: TR Reardon <thomas_reardon@hotmail.com> --- resize/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html