From patchwork Fri Nov 7 21:52:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Darrick Wong X-Patchwork-Id: 408279 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2D77E1400A6 for ; Sat, 8 Nov 2014 08:53:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752690AbaKGVxD (ORCPT ); Fri, 7 Nov 2014 16:53:03 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:36055 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752534AbaKGVxC (ORCPT ); Fri, 7 Nov 2014 16:53:02 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sA7Lr0l8018544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Nov 2014 21:53:00 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id sA7LqxA5006447 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 7 Nov 2014 21:52:59 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sA7LqwKP027056; Fri, 7 Nov 2014 21:52:59 GMT Received: from localhost (/71.198.20.188) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 07 Nov 2014 13:52:58 -0800 Subject: [PATCH 20/47] tune2fs: warn if extents are not enabled when turning on metadata_csum From: "Darrick J. Wong" To: tytso@mit.edu, darrick.wong@oracle.com Cc: linux-ext4@vger.kernel.org Date: Fri, 07 Nov 2014 13:52:57 -0800 Message-ID: <20141107215257.883.38333.stgit@birch.djwong.org> In-Reply-To: <20141107215042.883.49888.stgit@birch.djwong.org> References: <20141107215042.883.49888.stgit@birch.djwong.org> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Warn the user if we're trying to enable metadata_csum on a FS that doesn't support extents (since block maps cannot contain checksums). Signed-off-by: Darrick J. Wong --- misc/tune2fs.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/misc/tune2fs.c b/misc/tune2fs.c index 7fee870..6feaab1 100644 --- a/misc/tune2fs.c +++ b/misc/tune2fs.c @@ -1113,6 +1113,14 @@ mmp_error: if (mount_flags & EXT2_MF_MOUNTED) fputs(_("Cannot enable metadata_csum on a mounted " "filesystem!\n"), stderr); + if (!EXT2_HAS_INCOMPAT_FEATURE(fs->super, + EXT3_FEATURE_INCOMPAT_EXTENTS)) + printf("%s", + _("Extents are not enabled. The file extent " + "tree can be checksummed, whereas block maps " + "cannot. Not enabling extents reduces the " + "coverage of metadata checksumming. " + "Re-run with -O extent to rectify.\n")); rewrite_checksums = 1; /* metadata_csum supersedes uninit_bg */ fs->super->s_feature_ro_compat &=