From patchwork Tue Jul 22 17:47:36 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theodore Ts'o X-Patchwork-Id: 372591 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4A3D0140143 for ; Wed, 23 Jul 2014 06:35:15 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932143AbaGVUfJ (ORCPT ); Tue, 22 Jul 2014 16:35:09 -0400 Received: from imap.thunk.org ([74.207.234.97]:50618 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932135AbaGVUfG (ORCPT ); Tue, 22 Jul 2014 16:35:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=NKyBYN1ao2U7IEilewNNJQutmdo6BkbBPufSAMKMbHk=; b=vAr3DPwk+uTgry3axvhxIYmhe2rTbxobnM1DIuEy74hL/Wbo12C3QHN8GggKj4RY7jTHrmQZjUuJBtptakn//0wYhCK4gsJLNJDtTycUcgvmriFT0DK3P62dYIQefu9/ZZ/muWqcI/OWuHIM61cmlJZ6P304rY2X+v9FH7nl5ZY=; Received: from root (helo=closure.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.80) (envelope-from ) id 1X9gm9-0006vf-7G; Tue, 22 Jul 2014 20:35:05 +0000 Received: by closure.thunk.org (Postfix, from userid 15806) id 229CD581477; Tue, 22 Jul 2014 13:47:36 -0400 (EDT) Date: Tue, 22 Jul 2014 13:47:36 -0400 From: Theodore Ts'o To: "Darrick J. Wong" Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 03/24] debugfs: create idump command to dump an inode in hex Message-ID: <20140722174736.GG25291@thunk.org> References: <20140718225200.31374.85411.stgit@birch.djwong.org> <20140718225236.31374.97509.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140718225236.31374.97509.stgit@birch.djwong.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Jul 18, 2014 at 03:52:36PM -0700, Darrick J. Wong wrote: > Create a command that will dump an entire inode's space in hex. > > Signed-off-by: Darrick J. Wong Applied with the following addition which (a) adds a formal longer command name ("inode_dump") to be analogous with the "block_dump" command, and (b) adds an entry to the debugfs man page. - Ted --- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/debugfs/debug_cmds.ct b/debugfs/debug_cmds.ct index ef4c5c4..ed3728f 100644 --- a/debugfs/debug_cmds.ct +++ b/debugfs/debug_cmds.ct @@ -188,7 +188,7 @@ request do_zap_block, "Zap block: fill with 0, pattern, flip bits etc.", zap_block, zap; request do_block_dump, "Dump contents of a block", - block_dump, bd; + block_dump, bdump, bd; request do_list_quota, "List quota", list_quota, lq; @@ -196,8 +196,8 @@ request do_list_quota, "List quota", request do_get_quota, "Get quota", get_quota, gq; -request do_idump, "Dump inode", - idump; +request do_idump, "Dump the inode structure in hex", + inode_dump, idump, id; end; diff --git a/debugfs/debugfs.8.in b/debugfs/debugfs.8.in index 73254d3..9a125f6 100644 --- a/debugfs/debugfs.8.in +++ b/debugfs/debugfs.8.in @@ -346,6 +346,9 @@ showing its tree structure. Print a listing of the inodes which use the one or more blocks specified on the command line. .TP +.BI inode_dump " filespec" +Print the contents of the inode data structure in hex and ASCII format. +.TP .BI imap " filespec" Print the location of the inode data structure (in the inode table) of the inode