From patchwork Mon Apr 21 20:44:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Whitney X-Patchwork-Id: 340855 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id ADEC114018B for ; Tue, 22 Apr 2014 11:04:40 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754440AbaDUUo6 (ORCPT ); Mon, 21 Apr 2014 16:44:58 -0400 Received: from mail-yh0-f54.google.com ([209.85.213.54]:34476 "EHLO mail-yh0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753542AbaDUUo6 (ORCPT ); Mon, 21 Apr 2014 16:44:58 -0400 Received: by mail-yh0-f54.google.com with SMTP id f73so4022108yha.27 for ; Mon, 21 Apr 2014 13:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=974E+tb5Y7VTxcZjPk+1VQ5rab5r7YueEbTol3XM17o=; b=uUMgBR7ESQZ6IKQTkSSMVyXjRgJMdh8MewBnrubbR1GVRQkqlxxwVndPwQ+LS+ySvK jqdONPtngJ/w4ZXTMm/Z4IyK4XOBHjci7w9D9sfUrj2HGrfL3BAk6f99hbA+W86qYRhM jAVv9snuMCiwKGxBBroTzhO6wuEfUeXNY6fbpcFJpGuoL9kWQK1rfiyZoJkK7PM8fo9N B9Ags1uvkOen8/CkPar1tZU9YxAVx1wfadLySbZzpihd6ZBvzQ+fZhzMsOEbdUktmVlb te6JfGPh00ayKDiPzl6YZmFbXV0VwZUMvLnq9ZHJ5x3MOXp6S0NZukkhMmMT3f/bc9Fe r1TQ== X-Received: by 10.236.83.66 with SMTP id p42mr4806687yhe.122.1398113097903; Mon, 21 Apr 2014 13:44:57 -0700 (PDT) Received: from wallace (c-75-67-250-69.hsd1.nh.comcast.net. [75.67.250.69]) by mx.google.com with ESMTPSA id 46sm72881947yhg.36.2014.04.21.13.44.57 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 21 Apr 2014 13:44:57 -0700 (PDT) Date: Mon, 21 Apr 2014 16:44:54 -0400 From: Eric Whitney To: xfs@oss.sgi.com Cc: linux-ext4@vger.kernel.org Subject: [PATCH v3 3/3] generic: fix check for zero range support in generic/009 Message-ID: <20140421204454.GD960@wallace> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Generic/001 fails when run on a file system that does not support byte range zeroing. For example, an EOPNOTSUPP failure occurs when the test is run on a pre-3.15 extent-mapped file system. The code in the test intended to prevent this contains an apparent typo that results in a check for fallocate() rather than zero range support. v2: Use new helper function for the check. Signed-off-by: Eric Whitney --- tests/generic/009 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generic/009 b/tests/generic/009 index b7b0b3f..b4d3e4b 100644 --- a/tests/generic/009 +++ b/tests/generic/009 @@ -44,7 +44,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 # real QA test starts here _supported_os Linux -_require_xfs_io_falloc "fzero" +_require_xfs_io_falloc_zero testfile=$TEST_DIR/009.$$