From patchwork Fri Mar 14 02:44:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theodore Ts'o X-Patchwork-Id: 330172 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 826A32C00E5 for ; Fri, 14 Mar 2014 13:44:38 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754801AbaCNCoh (ORCPT ); Thu, 13 Mar 2014 22:44:37 -0400 Received: from imap.thunk.org ([74.207.234.97]:41179 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753692AbaCNCog (ORCPT ); Thu, 13 Mar 2014 22:44:36 -0400 Received: from root (helo=closure.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.80) (envelope-from ) id 1WOI6p-0002vb-A4; Fri, 14 Mar 2014 02:44:31 +0000 Received: by closure.thunk.org (Postfix, from userid 15806) id 11ADC580286; Thu, 13 Mar 2014 22:44:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=mail; t=1394765054; bh=bC7IzDrAE/RyA3vMKdeq2AYuzFnLhOwLo16GFzdabmc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V46d4AbO2dqqLgNVlPjyhn9yovtpsV7D3jghx073RMlZmF7tk4s2Z94xjX/7+N+0f XwhOX9Ghv3vtpqzlnaeKkEyW6QFsgMpaMyPASmD0j7evBG+DYKpoITqYHoSF6r7XIQ bi9R5qK05KLn38feVG0DKdCLc2GFrhnHfkwCi0ns= Date: Thu, 13 Mar 2014 22:44:13 -0400 From: Theodore Ts'o To: jon ernst Cc: "linux-ext4@vger.kernel.org List" Subject: Re: [PATCH v3 10/30] libext2fs: define new dirent_swab interfaces for inline data Message-ID: <20140314024413.GB8282@thunk.org> References: <1386323897-2354-1-git-send-email-wenqing.lz@taobao.com> <1386323897-2354-11-git-send-email-wenqing.lz@taobao.com> <20140303154950.GB9620@thunk.org> <392DED5B-9D1A-4989-A891-D844705DCA2D@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <392DED5B-9D1A-4989-A891-D844705DCA2D@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Mar 13, 2014 at 12:32:34PM -0400, jon ernst wrote: > errcode_t ext2fs_dirent_swab_in(ext2_filsys fs, char *buf, int flags) > { > + return ext2fs_dirent_swab_in(fs, buf, fs->blocksize, flags); > +} > > I guess it misses "2" for function name. > Should be: > > errcode_t ext2fs_dirent_swab_in(ext2_filsys fs, char *buf, int flags) > { > + return ext2fs_dirent_swab_in2(fs, buf, fs->blocksize, flags); > +} Nice catch, thanks!! - Ted From f9574ad0ba655b436b3940ff1604df4d11a43115 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Thu, 13 Mar 2014 13:40:37 -0400 Subject: [PATCH] libext2fs: fix build failure on big endian systems Fix a typo that we didn't notice because all the world's an x86. :-) Reported-by: jon ernst Signed-off-by: "Theodore Ts'o" --- lib/ext2fs/swapfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ext2fs/swapfs.c b/lib/ext2fs/swapfs.c index e3628b3..f08859b 100644 --- a/lib/ext2fs/swapfs.c +++ b/lib/ext2fs/swapfs.c @@ -363,7 +363,7 @@ void ext2fs_swap_mmp(struct mmp_struct *mmp) errcode_t ext2fs_dirent_swab_in(ext2_filsys fs, char *buf, int flags) { - return ext2fs_dirent_swab_in(fs, buf, fs->blocksize, flags); + return ext2fs_dirent_swab_in2(fs, buf, fs->blocksize, flags); } errcode_t ext2fs_dirent_swab_in2(ext2_filsys fs, char *buf,