diff mbox

[v3,10/30] libext2fs: define new dirent_swab interfaces for inline data

Message ID 20140314024413.GB8282@thunk.org
State Accepted, archived
Headers show

Commit Message

Theodore Ts'o March 14, 2014, 2:44 a.m. UTC 
On Thu, Mar 13, 2014 at 12:32:34PM -0400, jon ernst wrote:
> errcode_t ext2fs_dirent_swab_in(ext2_filsys fs, char *buf, int flags)
> {
> +       return ext2fs_dirent_swab_in(fs, buf, fs->blocksize, flags);
> +}
> 
> I guess it misses "2" for function name.
> Should be:
> 
> errcode_t ext2fs_dirent_swab_in(ext2_filsys fs, char *buf, int flags)
> {
> +       return ext2fs_dirent_swab_in2(fs, buf, fs->blocksize, flags);
> +}

Nice catch, thanks!!

					- Ted

From f9574ad0ba655b436b3940ff1604df4d11a43115 Mon Sep 17 00:00:00 2001
From: Theodore Ts'o <tytso@mit.edu>
Date: Thu, 13 Mar 2014 13:40:37 -0400
Subject: [PATCH] libext2fs: fix build failure on big endian systems

Fix a typo that we didn't notice because all the world's an x86.  :-)

Reported-by: jon ernst <jonernst07@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 lib/ext2fs/swapfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/lib/ext2fs/swapfs.c b/lib/ext2fs/swapfs.c
index e3628b3..f08859b 100644
--- a/lib/ext2fs/swapfs.c
+++ b/lib/ext2fs/swapfs.c
@@ -363,7 +363,7 @@  void ext2fs_swap_mmp(struct mmp_struct *mmp)
 
 errcode_t ext2fs_dirent_swab_in(ext2_filsys fs, char *buf, int flags)
 {
-	return ext2fs_dirent_swab_in(fs, buf, fs->blocksize, flags);
+	return ext2fs_dirent_swab_in2(fs, buf, fs->blocksize, flags);
 }
 
 errcode_t ext2fs_dirent_swab_in2(ext2_filsys fs, char *buf,