From patchwork Mon Oct 8 03:17:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Spelvin X-Patchwork-Id: 189882 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E73BC2C0254 for ; Mon, 8 Oct 2012 14:17:08 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751442Ab2JHDRG (ORCPT ); Sun, 7 Oct 2012 23:17:06 -0400 Received: from science.horizon.com ([71.41.210.146]:22542 "HELO science.horizon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751211Ab2JHDRG (ORCPT ); Sun, 7 Oct 2012 23:17:06 -0400 Received: (qmail 17731 invoked by uid 1000); 7 Oct 2012 23:17:04 -0400 Date: 7 Oct 2012 23:17:04 -0400 Message-ID: <20121008031704.17730.qmail@science.horizon.com> From: "George Spelvin" To: linux@horizon.com, tytso@mit.edu Subject: Re: metadata_csum + unclean shutdown = failure to boot Cc: linux-ext4@vger.kernel.org, tm@tao.ma In-Reply-To: <20121008024126.GC468@thunk.org> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org I'm testing that patch, but you may want to fix it a bit more before submitting to stable@... fs/ext4/resize.c: In function 'update_backups': fs/ext4/resize.c:973:39: error: too many arguments to function 'ext4_superblock_csum_set' In file included from fs/ext4/ext4_jbd2.h:20:0, from fs/ext4/resize.c:17: fs/ext4/ext4.h:2049:13: note: declared here The fix is of course obvious and I'm compiling it now. --- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 41f6ef6..e781259 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -970,7 +970,7 @@ static void update_backups(struct super_block *sb, goto exit_err; } - ext4_superblock_csum_set(sb, (struct ext4_super_block *)data); + ext4_superblock_csum_set(sb); while ((group = ext4_list_backups(sb, &three, &five, &seven)) < last) { struct buffer_head *bh;