From patchwork Fri Sep 23 22:14:01 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hartley Sweeten X-Patchwork-Id: 116183 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D2356B6F84 for ; Sat, 24 Sep 2011 08:14:33 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664Ab1IWWOT (ORCPT ); Fri, 23 Sep 2011 18:14:19 -0400 Received: from mail131.messagelabs.com ([216.82.242.99]:38369 "EHLO mail131.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752276Ab1IWWOT (ORCPT ); Fri, 23 Sep 2011 18:14:19 -0400 X-Env-Sender: hartleys@visionengravers.com X-Msg-Ref: server-2.tower-131.messagelabs.com!1316816052!1908650!3 X-Originating-IP: [216.166.12.32] X-StarScan-Version: 6.3.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7338 invoked from network); 23 Sep 2011 22:14:18 -0000 Received: from out001.collaborationhost.net (HELO out001.collaborationhost.net) (216.166.12.32) by server-2.tower-131.messagelabs.com with RC4-SHA encrypted SMTP; 23 Sep 2011 22:14:18 -0000 Received: from etch.local (10.2.3.210) by smtp.collaborationhost.net (10.2.0.47) with Microsoft SMTP Server (TLS) id 8.3.137.0; Fri, 23 Sep 2011 17:14:11 -0500 From: H Hartley Sweeten To: Linux Kernel Subject: [PATCH] ext4/fsync.c: functions should not be declared extern Date: Fri, 23 Sep 2011 15:14:01 -0700 User-Agent: KMail/1.9.9 CC: , , MIME-Version: 1.0 Content-Disposition: inline Message-ID: <201109231514.02174.hartleys@visionengravers.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org The function declaration in ext4.h is already marked extern. The function definition should not have the tag. This quiets the sparse noise: warning: function 'ext4_flush_completed_IO' with external linkage has definition Signed-off-by: H Hartley Sweeten Cc: "Theodore Ts'o" Cc: Andreas Dilger --- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 036f78f..c942924 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -75,7 +75,7 @@ static void dump_completed_IO(struct inode * inode) * to written. * The function return the number of pending IOs on success. */ -extern int ext4_flush_completed_IO(struct inode *inode) +int ext4_flush_completed_IO(struct inode *inode) { ext4_io_end_t *io; struct ext4_inode_info *ei = EXT4_I(inode);