| Message ID | 201003072132.10579.borntraeger@de.ibm.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 03/07/2010 03:32 PM, Christian Borntraeger wrote: > I have an x86_64 kernel with i386 userspace. e4defrag fails on the > EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat > case. It seems that struct move_extent is compat save, only types > with fixed widths are used: > { > __u32 reserved; /* should be zero */ > __u32 donor_fd; /* donor file descriptor */ > __u64 orig_start; /* logical start offset in block for orig */ > __u64 donor_start; /* logical start offset in block for donor */ > __u64 len; /* block length to be moved */ > __u64 moved_len; /* moved block length */ > }; > > Lets just wire up EXT4_IOC_MOVE_EXT for the compat case. > > Signed-off-by: Christian Borntraeger<borntraeger@de.ibm.com> > CCed: Akira Fujita<a-fujita@rs.jp.nec.com> I'm curious, what is the overall deployment status of ext4 defragging? I actually worked on this problem years ago[1], and am hopeful that I will see defragging in a Linux distribution sometime in my lifetime! ;-) Looking at Fedora rawhide, I do not see anything resembling e4defrag in any of the RPM packages like e2fsprogs. Thanks to everyone working on this, Jeff [1] http://linux.yyz.us/misc/ext2meta.c -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff Garzik wrote: > On 03/07/2010 03:32 PM, Christian Borntraeger wrote: >> I have an x86_64 kernel with i386 userspace. e4defrag fails on the >> EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat >> case. It seems that struct move_extent is compat save, only types >> with fixed widths are used: >> { >> __u32 reserved; /* should be zero */ >> __u32 donor_fd; /* donor file descriptor */ >> __u64 orig_start; /* logical start offset in block for >> orig */ >> __u64 donor_start; /* logical start offset in block for >> donor */ >> __u64 len; /* block length to be moved */ >> __u64 moved_len; /* moved block length */ >> }; >> >> Lets just wire up EXT4_IOC_MOVE_EXT for the compat case. >> >> Signed-off-by: Christian Borntraeger<borntraeger@de.ibm.com> >> CCed: Akira Fujita<a-fujita@rs.jp.nec.com> > > I'm curious, what is the overall deployment status of ext4 defragging? I > actually worked on this problem years ago[1], and am hopeful that I will > see defragging in a Linux distribution sometime in my lifetime! ;-) on ext4 you mean, I guess - you could use XFS if defragging is a high priority, see xfs_fsr(8) > Looking at Fedora rawhide, I do not see anything resembling e4defrag in > any of the RPM packages like e2fsprogs. I had it for a while, but with the various problems and general uneasiness with the code so far, I took it back out lest people lose data to it. -Eric > Thanks to everyone working on this, > > Jeff > > > > > [1] http://linux.yyz.us/misc/ext2meta.c -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Christian Borntraeger wrote: > I have an x86_64 kernel with i386 userspace. e4defrag fails on the > EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat > case. It seems that struct move_extent is compat save, only types > with fixed widths are used: and they're well-aligned. > { > __u32 reserved; /* should be zero */ > __u32 donor_fd; /* donor file descriptor */ > __u64 orig_start; /* logical start offset in block for orig */ > __u64 donor_start; /* logical start offset in block for donor */ > __u64 len; /* block length to be moved */ > __u64 moved_len; /* moved block length */ > }; > > Lets just wire up EXT4_IOC_MOVE_EXT for the compat case. > > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> > CCed: Akira Fujita <a-fujita@rs.jp.nec.com> Looks fine to me. Reviewed-by: Eric Sandeen <sandeen@redhat.com> > --- > fs/ext4/ioctl.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/fs/ext4/ioctl.c > +++ b/fs/ext4/ioctl.c > @@ -375,6 +375,8 @@ long ext4_compat_ioctl(struct file *file > break; > case EXT4_IOC_GROUP_ADD: > break; > + case EXT4_IOC_MOVE_EXT: > + break; > default: > return -ENOIOCTLCMD; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Christian, (2010/03/08 5:32), Christian Borntraeger wrote: > I have an x86_64 kernel with i386 userspace. e4defrag fails on the > EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat > case. It seems that struct move_extent is compat save, only types > with fixed widths are used: > { > __u32 reserved; /* should be zero */ > __u32 donor_fd; /* donor file descriptor */ > __u64 orig_start; /* logical start offset in block for orig */ > __u64 donor_start; /* logical start offset in block for donor */ > __u64 len; /* block length to be moved */ > __u64 moved_len; /* moved block length */ > }; > > Lets just wire up EXT4_IOC_MOVE_EXT for the compat case. > > Signed-off-by: Christian Borntraeger<borntraeger@de.ibm.com> > CCed: Akira Fujita<a-fujita@rs.jp.nec.com> > > --- > fs/ext4/ioctl.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/fs/ext4/ioctl.c > +++ b/fs/ext4/ioctl.c > @@ -375,6 +375,8 @@ long ext4_compat_ioctl(struct file *file > break; > case EXT4_IOC_GROUP_ADD: > break; > + case EXT4_IOC_MOVE_EXT: > + break; > default: > return -ENOIOCTLCMD; > } Looks good for me. Thank you for your work. Regards, Akira Fujita -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Mar 07, 2010 at 09:32:10PM +0100, Christian Borntraeger wrote: > I have an x86_64 kernel with i386 userspace. e4defrag fails on the > EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat > case. It seems that struct move_extent is compat save, only types > with fixed widths are used: > { > __u32 reserved; /* should be zero */ > __u32 donor_fd; /* donor file descriptor */ > __u64 orig_start; /* logical start offset in block for orig */ > __u64 donor_start; /* logical start offset in block for donor */ > __u64 len; /* block length to be moved */ > __u64 moved_len; /* moved block length */ > }; > > Lets just wire up EXT4_IOC_MOVE_EXT for the compat case. Thanks, added to the ext4 patch queue. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -375,6 +375,8 @@ long ext4_compat_ioctl(struct file *file break; case EXT4_IOC_GROUP_ADD: break; + case EXT4_IOC_MOVE_EXT: + break; default: return -ENOIOCTLCMD; }
I have an x86_64 kernel with i386 userspace. e4defrag fails on the EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat case. It seems that struct move_extent is compat save, only types with fixed widths are used: { __u32 reserved; /* should be zero */ __u32 donor_fd; /* donor file descriptor */ __u64 orig_start; /* logical start offset in block for orig */ __u64 donor_start; /* logical start offset in block for donor */ __u64 len; /* block length to be moved */ __u64 moved_len; /* moved block length */ }; Lets just wire up EXT4_IOC_MOVE_EXT for the compat case. Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> CCed: Akira Fujita <a-fujita@rs.jp.nec.com> --- fs/ext4/ioctl.c | 2 ++ 1 file changed, 2 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html