From patchwork Tue Mar 10 16:38:24 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: bugme-daemon@bugzilla.kernel.org X-Patchwork-Id: 24261 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id A2E47DDE11 for ; Wed, 11 Mar 2009 03:39:17 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754039AbZCJQjI (ORCPT ); Tue, 10 Mar 2009 12:39:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754652AbZCJQjH (ORCPT ); Tue, 10 Mar 2009 12:39:07 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:46271 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754039AbZCJQjG (ORCPT ); Tue, 10 Mar 2009 12:39:06 -0400 Received: from picon.linux-foundation.org (picon.linux-foundation.org [140.211.169.79]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n2AGcO49020945 for ; Tue, 10 Mar 2009 09:38:45 -0700 Received: by picon.linux-foundation.org (Postfix, from userid 65534) id 6C767108042; Tue, 10 Mar 2009 09:38:24 -0700 (PDT) Subject: [Bug 12829] kernel complains on ENOSPC In-Reply-To: X-Bugzilla-Product: File System X-Bugzilla-Severity: normal X-Bugzilla-Keywords: X-Bugzilla-Reason: AssignedTo X-Bugzilla-Component: ext4 To: linux-ext4@vger.kernel.org From: bugme-daemon@bugzilla.kernel.org Message-Id: <20090310163824.6C767108042@picon.linux-foundation.org> Date: Tue, 10 Mar 2009 09:38:24 -0700 (PDT) Received-SPF: none (domain of bugme-daemon@bugzilla.kernel.org does not designate permitted sender hosts) X-Spam-Status: No, hits=-3.284 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org http://bugzilla.kernel.org/show_bug.cgi?id=12829 ------- Comment #4 from aneesh.kumar@linux.vnet.ibm.com 2009-03-10 09:38 ------- This patch will not fix the problem. But i guess we need this change -aneesh diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 4415bee..671f215 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -4652,11 +4652,11 @@ out1: if (ar->len < inquota) DQUOT_FREE_BLOCK(ar->inode, inquota - ar->len); out3: - if (!ar->len) { + if (ar->len < reserv_blks) { if (!EXT4_I(ar->inode)->i_delalloc_reserved_flag) /* release all the reserved blocks if non delalloc */ percpu_counter_sub(&sbi->s_dirtyblocks_counter, - reserv_blks); + reserv_blks - ar->len); } trace_mark(ext4_allocate_blocks,