| Message ID | 20081211222622.GC18665@dastardly.home.dghda.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index ca88060..e70122e 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4200,9 +4200,10 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) inode->i_op = &ext4_dir_inode_operations; inode->i_fop = &ext4_dir_operations; } else if (S_ISLNK(inode->i_mode)) { - if (ext4_inode_is_fast_symlink(inode)) + if (ext4_inode_is_fast_symlink(inode)) { inode->i_op = &ext4_fast_symlink_inode_operations; - else { + ((char *) ei->i_data)[inode->i_size] = '\0'; + } else { inode->i_op = &ext4_symlink_inode_operations; ext4_set_aops(inode); }
Ensure link targets are NUL-terminated, even if corrupted on-disk. Signed-off-by: Duane Griffin <duaneg@dghda.com> --- V2: terminate when the link is read instead of every time it is followed, as suggested by Dave Kleikamp.