diff mbox

patch ext4-add-missing-unlock-in-ext4_check_descriptors-on-error-path.patch added to 2.6.27-stable tree

Message ID 20081203185913.E6B2A48D91@coco.kroah.org
State Not Applicable, archived
Headers show

Commit Message

gregkh@suse.de Dec. 3, 2008, 6:55 p.m. UTC
This is a note to let you know that we have just queued up the patch titled

    Subject: ext4: add missing unlock in ext4_check_descriptors() on error path

to the 2.6.27-stable tree.  Its filename is


A git repo of this tree can be found at 

From tytso@mit.edu  Wed Dec  3 09:57:50 2008
From: Li Zefan <lizf@cn.fujitsu.com>
Date: Sun, 16 Nov 2008 11:05:24 -0500
Subject: ext4: add missing unlock in ext4_check_descriptors() on error path
To: stable@kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>, Ext4 Developers List <linux-ext4@vger.kernel.org>, Li Zefan <lizf@cn.fujitsu.com>
Message-ID: <1226851540-8032-5-git-send-email-tytso@mit.edu>

From: Li Zefan <lizf@cn.fujitsu.com>

(cherry picked from commit 7ee1ec4ca30c6df8e989615cdaacb75f2af4fa6b)

If there group descriptors are corrupted we need unlock the block
group lock before returning from the function; else we will oops when
freeing a spinlock which is still being held.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

 fs/ext4/super.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patches currently in stable-queue which might be from lizf@cn.fujitsu.com are

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox


--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1626,8 +1626,10 @@  static int ext4_check_descriptors(struct
 			       "Checksum for group %lu failed (%u!=%u)\n",
 			       i, le16_to_cpu(ext4_group_desc_csum(sbi, i,
 			       gdp)), le16_to_cpu(gdp->bg_checksum));
-			if (!(sb->s_flags & MS_RDONLY))
+			if (!(sb->s_flags & MS_RDONLY)) {
+				spin_unlock(sb_bgl_lock(sbi, i));
 				return 0;
+			}
 		spin_unlock(sb_bgl_lock(sbi, i));
 		if (!flexbg_flag)