From patchwork Wed Dec 3 18:55:46 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gregkh@suse.de X-Patchwork-Id: 11958 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id A0B0A474C1 for ; Thu, 4 Dec 2008 05:59:17 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751605AbYLCS7N (ORCPT ); Wed, 3 Dec 2008 13:59:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751584AbYLCS7N (ORCPT ); Wed, 3 Dec 2008 13:59:13 -0500 Received: from kroah.org ([198.145.64.141]:60890 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751349AbYLCS7M (ORCPT ); Wed, 3 Dec 2008 13:59:12 -0500 Received: from localhost (mail.kroah.net [66.93.40.174]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by coco.kroah.org (Postfix) with ESMTPSA id 7EBED48D80; Wed, 3 Dec 2008 10:59:11 -0800 (PST) Subject: patch ext4-add-checksum-calculation-when-clearing-uninit-flag-in-ext4_new_inode.patch added to 2.6.27-stable tree To: frederic.bohe@bull.net, gregkh@suse.de, linux-ext4@vger.kernel.org, tytso@mit.edu Cc: , From: Date: Wed, 03 Dec 2008 10:55:46 -0800 In-Reply-To: <1226851540-8032-21-git-send-email-tytso@mit.edu> Message-Id: <20081203185911.7EBED48D80@coco.kroah.org> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org This is a note to let you know that we have just queued up the patch titled Subject: ext4: add checksum calculation when clearing UNINIT flag in ext4_new_inode to the 2.6.27-stable tree. Its filename is ext4-add-checksum-calculation-when-clearing-uninit-flag-in-ext4_new_inode.patch A git repo of this tree can be found at http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary From tytso@mit.edu Wed Dec 3 10:45:18 2008 From: Frederic Bohe Date: Sun, 16 Nov 2008 11:05:40 -0500 Subject: ext4: add checksum calculation when clearing UNINIT flag in ext4_new_inode To: stable@kernel.org Cc: Frederic Bohe , Ext4 Developers List , "Theodore Ts'o" Message-ID: <1226851540-8032-21-git-send-email-tytso@mit.edu> From: Frederic Bohe (cherry picked from commit 23712a9c28b9f80a8cf70c8490358d5f562d2465) When initializing an uninitialized block group in ext4_new_inode(), its block group checksum must be re-calculated. This fixes a race when several threads try to allocate a new inode in an UNINIT'd group. There is some question whether we need to be initializing the block bitmap in ext4_new_inode() at all, but for now, if we are going to init the block group, let's eliminate the race. Signed-off-by: Frederic Bohe Signed-off-by: "Theodore Ts'o" Signed-off-by: Greg Kroah-Hartman --- fs/ext4/ialloc.c | 2 ++ 1 file changed, 2 insertions(+) Patches currently in stable-queue which might be from frederic.bohe@bull.net are queue-2.6.27/ext4-update-flex_bg-free-blocks-and-free-inodes-counters-when-resizing.patch queue-2.6.27/ext4-fix-initialization-of-uninit-bitmap-blocks.patch queue-2.6.27/ext4-add-checksum-calculation-when-clearing-uninit-flag-in-ext4_new_inode.patch -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -717,6 +717,8 @@ got: gdp->bg_flags &= cpu_to_le16(~EXT4_BG_BLOCK_UNINIT); free = ext4_free_blocks_after_init(sb, group, gdp); gdp->bg_free_blocks_count = cpu_to_le16(free); + gdp->bg_checksum = ext4_group_desc_csum(sbi, group, + gdp); } spin_unlock(sb_bgl_lock(sbi, group));