From patchwork Wed Nov 12 21:27:01 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 8450 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 76885DDDD4 for ; Thu, 13 Nov 2008 08:36:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755703AbYKLVfX (ORCPT ); Wed, 12 Nov 2008 16:35:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755691AbYKLVfW (ORCPT ); Wed, 12 Nov 2008 16:35:22 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:38753 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755681AbYKLVfU (ORCPT ); Wed, 12 Nov 2008 16:35:20 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id mACLYtD7026477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Nov 2008 13:34:57 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id mACLR16j026874; Wed, 12 Nov 2008 13:27:01 -0800 Message-Id: <200811122127.mACLR16j026874@imap1.linux-foundation.org> Subject: [patch 21/34] ext3: Clean up outdated and incorrect comment for ext3_write_super() To: torvalds@linux-foundation.org Cc: akpm@linux-foundation.org, tytso@mit.edu, linux-ext4@vger.kernel.org From: akpm@linux-foundation.org Date: Wed, 12 Nov 2008 13:27:01 -0800 X-Spam-Status: No, hits=-3.382 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Theodore Tso Signed-off-by: "Theodore Ts'o" Cc: Signed-off-by: Andrew Morton --- fs/ext3/super.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff -puN fs/ext3/super.c~ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super fs/ext3/super.c --- a/fs/ext3/super.c~ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super +++ a/fs/ext3/super.c @@ -2375,12 +2375,9 @@ int ext3_force_commit(struct super_block /* * Ext3 always journals updates to the superblock itself, so we don't * have to propagate any other updates to the superblock on disk at this - * point. Just start an async writeback to get the buffers on their way - * to the disk. - * - * This implicitly triggers the writebehind on sync(). + * point. (We can probably nuke this function altogether, and remove + * any mention to sb->s_dirt in all of fs/ext3; eventual cleanup...) */ - static void ext3_write_super (struct super_block * sb) { if (mutex_trylock(&sb->s_lock) != 0)