From patchwork Wed Nov 12 00:34:46 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 8243 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 5D59FDDE00 for ; Wed, 12 Nov 2008 11:35:53 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754824AbYKLAfd (ORCPT ); Tue, 11 Nov 2008 19:35:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753625AbYKLAfc (ORCPT ); Tue, 11 Nov 2008 19:35:32 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:54087 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754305AbYKLAfa (ORCPT ); Tue, 11 Nov 2008 19:35:30 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id mAC0YkYc000907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Nov 2008 16:34:47 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id mAC0YkcO015566; Tue, 11 Nov 2008 16:34:46 -0800 Message-Id: <200811120034.mAC0YkcO015566@imap1.linux-foundation.org> Subject: + ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super.patch added to -mm tree To: mm-commits@vger.kernel.org Cc: tytso@mit.edu, linux-ext4@vger.kernel.org From: akpm@linux-foundation.org Date: Tue, 11 Nov 2008 16:34:46 -0800 X-Spam-Status: No, hits=-2.882 required=5 tests=AWL,BAYES_00 X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org The patch titled ext3: Clean up outdated and incorrect comment for ext3_write_super() has been added to the -mm tree. Its filename is ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: ext3: Clean up outdated and incorrect comment for ext3_write_super() From: Theodore Tso Signed-off-by: "Theodore Ts'o" Cc: Signed-off-by: Andrew Morton --- fs/ext3/super.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff -puN fs/ext3/super.c~ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super fs/ext3/super.c --- a/fs/ext3/super.c~ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super +++ a/fs/ext3/super.c @@ -2375,12 +2375,9 @@ int ext3_force_commit(struct super_block /* * Ext3 always journals updates to the superblock itself, so we don't * have to propagate any other updates to the superblock on disk at this - * point. Just start an async writeback to get the buffers on their way - * to the disk. - * - * This implicitly triggers the writebehind on sync(). + * point. (We can probably nuke this function altogether, and remove + * any mention to sb->s_dirt in all of fs/ext3; eventual cleanup...) */ - static void ext3_write_super (struct super_block * sb) { if (mutex_trylock(&sb->s_lock) != 0)