From patchwork Thu Nov 6 23:51:19 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 7622 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 347A0DDE11 for ; Fri, 7 Nov 2008 10:51:38 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752831AbYKFXv3 (ORCPT ); Thu, 6 Nov 2008 18:51:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752927AbYKFXv3 (ORCPT ); Thu, 6 Nov 2008 18:51:29 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53168 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752705AbYKFXvZ (ORCPT ); Thu, 6 Nov 2008 18:51:25 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id mA6NpJmo015854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 6 Nov 2008 15:51:20 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id mA6NpJwS030257; Thu, 6 Nov 2008 15:51:19 -0800 Message-Id: <200811062351.mA6NpJwS030257@imap1.linux-foundation.org> Subject: - quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes.patch removed from -mm tree To: akpm@linux-foundation.org, cmm@us.ibm.com, jack@ucw.cz, linux-ext4@vger.kernel.org, mm-commits@vger.kernel.org From: akpm@linux-foundation.org Date: Thu, 06 Nov 2008 15:51:19 -0800 X-Spam-Status: No, hits=-2.873 required=5 tests=AWL,BAYES_00 X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org The patch titled quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes has been removed from the -mm tree. Its filename was quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes.patch This patch was dropped because an updated version will be merged The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes From: Andrew Morton WARNING: line over 80 characters #68: FILE: include/linux/quota.h:296: + int (*claim_space) (struct inode *, qsize_t); /* claim reserved quota for delayed block allocation */ WARNING: line over 80 characters #69: FILE: include/linux/quota.h:297: + void (*release_rsv) (struct inode *, qsize_t); /* release reserved quota for delayed block allocation */ ERROR: space required before the open brace '{' #98: FILE: include/linux/quotaops.h:209: + if (sb_any_quota_active(inode->i_sb)){ ERROR: else should follow close brace '}' #102: FILE: include/linux/quotaops.h:213: + } + else WARNING: line over 80 characters #112: FILE: include/linux/quotaops.h:223: +static inline void vfs_dq_release_reservation_space(struct inode *inode, qsize_t nr) WARNING: line over 80 characters #130: FILE: include/linux/quotaops.h:380: +static inline int vfs_dq_release_reservation_space(struct inode *inode, qsize_t nr) WARNING: line over 80 characters #150: FILE: include/linux/quotaops.h:437: + vfs_dq_release_reservation_space(inode, nr << inode->i_sb->s_blocksize_bits); WARNING: printk() should include KERN_ facility level #180: FILE: fs/dquot.c:856: + printk("WARNING: reserved quota %llu is not enough for" WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #270: FILE: fs/dquot.c:2436: +EXPORT_SYMBOL(dquot_claim_space); WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #271: FILE: fs/dquot.c:2437: +EXPORT_SYMBOL(dquot_release_reserved_space); total: 2 errors, 8 warnings, 194 lines checked ./patches/quota-add-quota-claim-and-release-reserved-quota-blocks-operations.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Cc: Jan Kara Cc: Mingming Cao Signed-off-by: Andrew Morton --- include/linux/quotaops.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff -puN include/linux/quotaops.h~quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes include/linux/quotaops.h --- a/include/linux/quotaops.h~quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes +++ a/include/linux/quotaops.h @@ -206,11 +206,10 @@ static inline int vfs_dq_alloc_inode(str */ static inline int vfs_dq_claim_space(struct inode *inode, qsize_t nr) { - if (sb_any_quota_active(inode->i_sb)){ + if (sb_any_quota_active(inode->i_sb)) { if (inode->i_sb->dq_op->claim_space(inode, nr) == NO_QUOTA) return 1; - } - else + } else inode_add_bytes(inode, nr); mark_inode_dirty(inode);