| Message ID | 200811062351.mA6NpJwS030257@imap1.linux-foundation.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
diff -puN include/linux/quotaops.h~quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes include/linux/quotaops.h --- a/include/linux/quotaops.h~quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes +++ a/include/linux/quotaops.h @@ -206,11 +206,10 @@ static inline int vfs_dq_alloc_inode(str */ static inline int vfs_dq_claim_space(struct inode *inode, qsize_t nr) { - if (sb_any_quota_active(inode->i_sb)){ + if (sb_any_quota_active(inode->i_sb)) { if (inode->i_sb->dq_op->claim_space(inode, nr) == NO_QUOTA) return 1; - } - else + } else inode_add_bytes(inode, nr); mark_inode_dirty(inode);
The patch titled quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes has been removed from the -mm tree. Its filename was quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes.patch This patch was dropped because an updated version will be merged The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: quota-add-quota-claim-and-release-reserved-quota-blocks-operations-checkpatch-fixes From: Andrew Morton <akpm@linux-foundation.org> WARNING: line over 80 characters #68: FILE: include/linux/quota.h:296: + int (*claim_space) (struct inode *, qsize_t); /* claim reserved quota for delayed block allocation */ WARNING: line over 80 characters #69: FILE: include/linux/quota.h:297: + void (*release_rsv) (struct inode *, qsize_t); /* release reserved quota for delayed block allocation */ ERROR: space required before the open brace '{' #98: FILE: include/linux/quotaops.h:209: + if (sb_any_quota_active(inode->i_sb)){ ERROR: else should follow close brace '}' #102: FILE: include/linux/quotaops.h:213: + } + else WARNING: line over 80 characters #112: FILE: include/linux/quotaops.h:223: +static inline void vfs_dq_release_reservation_space(struct inode *inode, qsize_t nr) WARNING: line over 80 characters #130: FILE: include/linux/quotaops.h:380: +static inline int vfs_dq_release_reservation_space(struct inode *inode, qsize_t nr) WARNING: line over 80 characters #150: FILE: include/linux/quotaops.h:437: + vfs_dq_release_reservation_space(inode, nr << inode->i_sb->s_blocksize_bits); WARNING: printk() should include KERN_ facility level #180: FILE: fs/dquot.c:856: + printk("WARNING: reserved quota %llu is not enough for" WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #270: FILE: fs/dquot.c:2436: +EXPORT_SYMBOL(dquot_claim_space); WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #271: FILE: fs/dquot.c:2437: +EXPORT_SYMBOL(dquot_release_reserved_space); total: 2 errors, 8 warnings, 194 lines checked ./patches/quota-add-quota-claim-and-release-reserved-quota-blocks-operations.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: <linux-ext4@vger.kernel.org> Cc: Jan Kara <jack@ucw.cz> Cc: Mingming Cao <cmm@us.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- include/linux/quotaops.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)