From patchwork Thu Oct 16 07:26:14 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Sesterhenn X-Patchwork-Id: 4661 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id B6FA7DDF94 for ; Thu, 16 Oct 2008 18:37:18 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752455AbYJPH0S (ORCPT ); Thu, 16 Oct 2008 03:26:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752465AbYJPH0S (ORCPT ); Thu, 16 Oct 2008 03:26:18 -0400 Received: from mail.gmx.net ([213.165.64.20]:32829 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752455AbYJPH0S (ORCPT ); Thu, 16 Oct 2008 03:26:18 -0400 Received: (qmail invoked by alias); 16 Oct 2008 07:26:15 -0000 Received: from dslb-084-058-128-147.pools.arcor-ip.net (EHLO gmx.net) [84.58.128.147] by mail.gmx.net (mp058) with SMTP; 16 Oct 2008 09:26:15 +0200 X-Authenticated: #704063 X-Provags-ID: V01U2FsdGVkX18TDSQQolITmWvMO/wVzezqLRHPU/6dRgqbqA4BuW SGJIQ5IyM2xs24 Date: Thu, 16 Oct 2008 09:26:14 +0200 From: Eric Sesterhenn To: tytso@mit.edu, adilger@sun.com Cc: linux-ext4@vger.kernel.org Subject: [PATCH] ext4 missing newlines Message-ID: <20081016072614.GA23730@alice> MIME-Version: 1.0 Content-Disposition: inline X-Editor: Vim http://www.vim.org/ X-Info: http://www.snake-basket.de X-Operating-System: Linux/2.6.27-rc8 (x86_64) X-Uptime: 09:23:50 up 4 days, 22 min, 8 users, load average: 2.04, 1.25, 1.33 User-Agent: Mutt/1.5.16 (2007-06-09) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.54 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org hi, there are some newlines missing in ext4_check_descriptors, which cause the printk level to be printed out when the next printk call is made: [ 778.847265] EXT4-fs: ext4_check_descriptors: Block bitmap for group 0 not in group (block 1509949442)!<3>EXT4-fs: group descriptors corrupted! [ 802.646630] EXT4-fs: ext4_check_descriptors: Inode bitmap for group 0 not in group (block 9043971)!<3>EXT4-fs: group descriptors corrupted! Signed-off-by: Eric Sesterhenn --- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux/fs/ext4/super.c.orig 2008-10-16 09:19:19.000000000 +0200 +++ linux/fs/ext4/super.c 2008-10-16 09:19:50.000000000 +0200 @@ -1618,14 +1618,14 @@ static int ext4_check_descriptors(struct if (block_bitmap < first_block || block_bitmap > last_block) { printk(KERN_ERR "EXT4-fs: ext4_check_descriptors: " "Block bitmap for group %lu not in group " - "(block %llu)!", i, block_bitmap); + "(block %llu)!\n", i, block_bitmap); return 0; } inode_bitmap = ext4_inode_bitmap(sb, gdp); if (inode_bitmap < first_block || inode_bitmap > last_block) { printk(KERN_ERR "EXT4-fs: ext4_check_descriptors: " "Inode bitmap for group %lu not in group " - "(block %llu)!", i, inode_bitmap); + "(block %llu)!\n", i, inode_bitmap); return 0; } inode_table = ext4_inode_table(sb, gdp); @@ -1633,7 +1633,7 @@ static int ext4_check_descriptors(struct inode_table + sbi->s_itb_per_group - 1 > last_block) { printk(KERN_ERR "EXT4-fs: ext4_check_descriptors: " "Inode table for group %lu not in group " - "(block %llu)!", i, inode_table); + "(block %llu)!\n", i, inode_table); return 0; } spin_lock(sb_bgl_lock(sbi, i));