diff mbox series

ext4: remove redundant operation that set bh to NULL

Message ID 1603194069-17557-1-git-send-email-kaixuxia@tencent.com
State New
Headers show
Series ext4: remove redundant operation that set bh to NULL | expand

Commit Message

kaixuxia Oct. 20, 2020, 11:41 a.m. UTC
From: Kaixu Xia <kaixuxia@tencent.com>

The out_fail branch path don't release the bh and the second bh is
valid only in the for statement, so we don't need to set them to NULL.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
 fs/ext4/super.c | 2 --
 1 file changed, 2 deletions(-)

Comments

zhangyi (F) Oct. 21, 2020, 1:10 a.m. UTC | #1
On 2020/10/20 19:41, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
> 
> The out_fail branch path don't release the bh and the second bh is
> valid only in the for statement, so we don't need to set them to NULL.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>

Thanks for the patch. It looks good to me.
Reviewed-by: zhangyi (F) <yi.zhang@huawei.com>

Yi.

> ---
>  fs/ext4/super.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 5308f0d5fb5a..3ebfabc6061a 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4093,7 +4093,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
>  	if (IS_ERR(bh)) {
>  		ext4_msg(sb, KERN_ERR, "unable to read superblock");
>  		ret = PTR_ERR(bh);
> -		bh = NULL;
>  		goto out_fail;
>  	}
>  	/*
> @@ -4721,7 +4720,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
>  			       "can't read group descriptor %d", i);
>  			db_count = i;
>  			ret = PTR_ERR(bh);
> -			bh = NULL;
>  			goto failed_mount2;
>  		}
>  		rcu_read_lock();
>
diff mbox series

Patch

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 5308f0d5fb5a..3ebfabc6061a 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4093,7 +4093,6 @@  static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 	if (IS_ERR(bh)) {
 		ext4_msg(sb, KERN_ERR, "unable to read superblock");
 		ret = PTR_ERR(bh);
-		bh = NULL;
 		goto out_fail;
 	}
 	/*
@@ -4721,7 +4720,6 @@  static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 			       "can't read group descriptor %d", i);
 			db_count = i;
 			ret = PTR_ERR(bh);
-			bh = NULL;
 			goto failed_mount2;
 		}
 		rcu_read_lock();