diff mbox

ext4: fix spelling of "don't"

Message ID 1490073611.313465.918041856.1A5E4239@webmail.messagingengine.com
State Rejected, archived
Headers show

Commit Message

Benjamin Peterson March 21, 2017, 5:20 a.m. UTC
Signed-off-by: Benjamin Peterson <bp@benjamin.pe>
---
 fs/ext4/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-        * others doen't incorrectly think the file is completely
sparse.
+        * others don't incorrectly think the file is completely sparse.
 	 */
 	if (unlikely(ext4_has_inline_data(inode)))
 		stat->blocks += (stat->size + 511) >> 9;

Comments

Theodore Ts'o March 25, 2017, 7:55 p.m. UTC | #1
On Mon, Mar 20, 2017 at 10:20:11PM -0700, Benjamin Peterson wrote:
> Signed-off-by: Benjamin Peterson <bp@benjamin.pe>

Hi Benjamin,

	I generally don't take spelling fixes unless it's part of a
related code change.  If you are a beginning kernel developer, most of
kernelnewbies tutorials advise beginners to send patches to the code
in the drivers/staging directory.

Also, please note that this patch arrived white-space damaged.  I'm
guessing it's because you are using a web-based engine, and it
line-wraped the patch, thus damaging it:

> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 7385e6a..4247d8d 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5400,7 +5400,7 @@ int ext4_getattr(const struct path *path, struct
> kstat *stat,
>  	 * If there is inline data in the inode, the inode will normally
>  	 not
         ^^^^ webmail damage
>  	 * have data blocks allocated (it may have an external xattr
>  	 block).
         ^^^^ webmail damage

>  	 * Report at least one sector for such files, so tools like tar,
>  	 rsync,
         ^^^^ webmail damage
> -        * others doen't incorrectly think the file is completely
> sparse.
  ^^^^ webmail damage
> +        * others don't incorrectly think the file is completely sparse.
>  	 */
>  	if (unlikely(ext4_has_inline_data(inode)))
>  		stat->blocks += (stat->size + 511) >> 9;

Cheers,

					- Ted
diff mbox

Patch

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 7385e6a..4247d8d 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5400,7 +5400,7 @@  int ext4_getattr(const struct path *path, struct
kstat *stat,
 	 * If there is inline data in the inode, the inode will normally
 	 not
 	 * have data blocks allocated (it may have an external xattr
 	 block).
 	 * Report at least one sector for such files, so tools like tar,
 	 rsync,