From patchwork Tue Jul 5 07:00:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Shilong X-Patchwork-Id: 644578 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rkGWM3F4rz9sBc for ; Tue, 5 Jul 2016 17:59:43 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=0xRuZggg; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754189AbcGEH7l (ORCPT ); Tue, 5 Jul 2016 03:59:41 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:34779 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830AbcGEH7k (ORCPT ); Tue, 5 Jul 2016 03:59:40 -0400 Received: by mail-pa0-f66.google.com with SMTP id us13so17754736pab.1 for ; Tue, 05 Jul 2016 00:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=mCYeK75L5UMnFKkU/wlTIrZxTQqDiMozQIkM4GWtKGM=; b=0xRuZgggZXJrv+ApPvRiZIHsEGlthxUJfi8Tfxt4QdelY/UNfprxuEA18uWXZgXeeO lNbSbqYLJKeDnrQiL6h5pmFhAqm/8fgC8Q0ww57sVaAASmuKDsRbjc8QzTYje8x7mVN0 Jdh2GZ3K0olYOlXjEpHEG3hZafqUz3sY9lKlVHUncPiQEBNt3Pp/bGTxmICnSo3XTjMz Y96W779cGexFXmea8CZIUh8ROPckSOotRCFDewfUfJVnbDM6MF2Nav/cj0KunDEivm+u NMatlAOzClfxuBl9v17nqK8IpffJEYny7UTLQSu1BCK0NXeggjXIzXe0irTOVRGdhRw9 aIjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=mCYeK75L5UMnFKkU/wlTIrZxTQqDiMozQIkM4GWtKGM=; b=mg3CHyYt3HkGKXaAeqR5eFYU2D8Wr4IkqDAXNst11eFWo0eQJJqJGt4yR1dQy3HeM5 DO2NU0AZ0f1f5z1UG4Gb/KhObEOT/CEtqMzzFdcl0yUKRe1WaxTEAlGWQlMNsxAJs/v9 sIF0ZkmISU25cm/WK1oiGMNlRyo60fjulnrLqNJDFYis+HmSoudl8/0Eyvgp5nYrXEX8 O0mXVur2fTm43mDY9u0DZgXor9jJDCGSIrrhoRI6qY6ypR1GYE2FMkUNAhSy7/mg0Sqs IFl6FaPQ079imOiLcXQAVxfjTDmnK5g8FAKO+VmDaL56DsRSHz+g71l66+o1+xHX0SUR WSrg== X-Gm-Message-State: ALyK8tLit+/danreFPS2KIxwx1ZLHLTLEmGSYu+hUt0MxWJSNIFSNIrC7cOgUnw6fVckPw== X-Received: by 10.66.73.193 with SMTP id n1mr30104690pav.70.1467705579672; Tue, 05 Jul 2016 00:59:39 -0700 (PDT) Received: from localhost.localdomain ([45.32.49.168]) by smtp.gmail.com with ESMTPSA id an13sm3003935pac.42.2016.07.05.00.59.33 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 05 Jul 2016 00:59:38 -0700 (PDT) From: Wang Shilong To: jack@suse.cz Cc: linux-ext4@vger.kernel.org, sihara@ddn.com, lixi@ddn.com, Wang Shilong Subject: [PATCH] quota: fix coredump if projid file dose not exist Date: Tue, 5 Jul 2016 16:00:40 +0900 Message-Id: <1467702040-14764-1-git-send-email-wangshilong1991@gmail.com> X-Mailer: git-send-email 2.7.4 (Apple Git-66) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Wang Shilong if '/etc/projid' dose not exist,@project_file will be NULL pointer, fclose will cause coredump, add check in endprent(). Signed-off-by: Wang Shilong --- quotasys.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/quotasys.c b/quotasys.c index c78e02c..d04f25a 100644 --- a/quotasys.c +++ b/quotasys.c @@ -98,8 +98,10 @@ void setprent(void) /* Close /etc/projid file */ void endprent(void) { - fclose(project_file); - project_file = NULL; + if (project_file) { + fclose(project_file); + project_file = NULL; + } } /* Get next entry in /etc/projid */