diff mbox

fix compile error while opening the macro DOUBLE_CHECK

Message ID 1448960309-27346-1-git-send-email-zhangaihua1@huawei.com
State Accepted, archived
Headers show

Commit Message

zhangaihua1@huawei.com Dec. 1, 2015, 8:58 a.m. UTC 
From: Aihua Zhang <zhangaihua1@huawei.com>

the error is:
    fs/ext4/mballoc.c:475:43: error: 'struct ext4_group_info' has
no member named 'bb_bitmap'.
    so, the definition of macro DOUBLE_CHECK should before
'struct ext4_group_info', I fixed it, and I moved the macro
AGGRESSIVE_CHECK together, because I think they shoule be together.

Signed-off-by: Aihua Zhang <zhangaihua1@huawei.com>
---
 fs/ext4/ext4.h    |   12 ++++++++++++
 fs/ext4/mballoc.h |   12 ------------
 2 files changed, 12 insertions(+), 12 deletions(-)

Comments

Theodore Ts'o March 13, 2016, 9:19 p.m. UTC | #1 
On Tue, Dec 01, 2015 at 04:58:29PM +0800, zhangaihua1@huawei.com wrote:
> From: Aihua Zhang <zhangaihua1@huawei.com>
> 
> the error is:
>     fs/ext4/mballoc.c:475:43: error: 'struct ext4_group_info' has
> no member named 'bb_bitmap'.
>     so, the definition of macro DOUBLE_CHECK should before
> 'struct ext4_group_info', I fixed it, and I moved the macro
> AGGRESSIVE_CHECK together, because I think they shoule be together.
> 
> Signed-off-by: Aihua Zhang <zhangaihua1@huawei.com>

Applied, thanks.  Apologies for the delay.

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 750063f..04a3732 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -41,6 +41,18 @@ 
  */
 
 /*
+ * with AGGRESSIVE_CHECK allocator runs consistency checks over
+ * structures. these checks slow things down a lot
+ */
+#define AGGRESSIVE_CHECK__
+
+/*
+ * with DOUBLE_CHECK defined mballoc creates persistent in-core
+ * bitmaps, maintains and uses them to check for double allocations
+ */
+#define DOUBLE_CHECK__
+
+/*
  * Define EXT4FS_DEBUG to produce debug messages
  */
 #undef EXT4FS_DEBUG
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index d634e18..3ef1df6 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -23,18 +23,6 @@ 
 #include "ext4.h"
 
 /*
- * with AGGRESSIVE_CHECK allocator runs consistency checks over
- * structures. these checks slow things down a lot
- */
-#define AGGRESSIVE_CHECK__
-
-/*
- * with DOUBLE_CHECK defined mballoc creates persistent in-core
- * bitmaps, maintains and uses them to check for double allocations
- */
-#define DOUBLE_CHECK__
-
-/*
  */
 #ifdef CONFIG_EXT4_DEBUG
 extern ushort ext4_mballoc_debug;