From patchwork Tue Jan 7 14:53:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theodore Ts'o X-Patchwork-Id: 307662 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E43402C00E3 for ; Wed, 8 Jan 2014 01:53:27 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751860AbaAGOxZ (ORCPT ); Tue, 7 Jan 2014 09:53:25 -0500 Received: from imap.thunk.org ([74.207.234.97]:46595 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbaAGOxV (ORCPT ); Tue, 7 Jan 2014 09:53:21 -0500 Received: from root (helo=closure.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.80) (envelope-from ) id 1W0Y1w-0005Es-3m; Tue, 07 Jan 2014 14:53:20 +0000 Received: by closure.thunk.org (Postfix, from userid 15806) id 0DA365802D4; Tue, 7 Jan 2014 09:53:18 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=mail; t=1389106399; bh=WxuVQRvl2AYy3xyJHqw1D1DWVEyiPBkCb135FC1x+7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IRZZLY4RrRtHucar9+QJ1JWcfNvLnwdaFSZuhys2ubASj6j72jZelUcyOQu1Xx6Tl E4DH/+e2RaOVz2Jk32skByzFJLbCZ6QtX8UIsY/bH83SKOPwy0CWoSCOM6wx/brnCE 5wWSwYzVHJM9GDeLFiD1OxWdH5MSKZzbQ/hnaQQw= From: Theodore Ts'o To: Ext4 Developers List Cc: Theodore Ts'o Subject: [PATCH 03/10] e2fsck: fix memory leak on error path in read_bad_blocks_files() Date: Tue, 7 Jan 2014 09:53:07 -0500 Message-Id: <1389106394-31898-3-git-send-email-tytso@mit.edu> X-Mailer: git-send-email 1.8.5.rc3.362.gdf10213 In-Reply-To: <1389106394-31898-1-git-send-email-tytso@mit.edu> References: <1389106394-31898-1-git-send-email-tytso@mit.edu> X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Addresses-Coverity-Id: #1049170 Signed-off-by: "Theodore Ts'o" --- e2fsck/badblocks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/e2fsck/badblocks.c b/e2fsck/badblocks.c index 8519df0..7f3641b 100644 --- a/e2fsck/badblocks.c +++ b/e2fsck/badblocks.c @@ -111,6 +111,8 @@ void read_bad_blocks_file(e2fsck_t ctx, const char *bad_blocks_file, fatal: ctx->flags |= E2F_FLAG_ABORT; + if (bb_list) + ext2fs_badblocks_list_free(bb_list); return; }