From patchwork Fri Apr 26 19:16:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 240012 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3E9E32C0111 for ; Sat, 27 Apr 2013 05:16:57 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757499Ab3DZTQ4 (ORCPT ); Fri, 26 Apr 2013 15:16:56 -0400 Received: from dkim2.fusionio.com ([66.114.96.54]:58072 "EHLO dkim2.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757466Ab3DZTQz (ORCPT ); Fri, 26 Apr 2013 15:16:55 -0400 Received: from mx1.fusionio.com (unknown [10.101.1.160]) by dkim2.fusionio.com (Postfix) with ESMTP id 9FE799A033F for ; Fri, 26 Apr 2013 13:16:55 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1367003815; bh=x+hl+rUOfQh7xO2z0YPEPnSsRvJlFOqrgne5sXRzZqo=; h=From:To:Subject:Date; b=rx0NqwsHCL+ICDzgKzkLKIiApcOWLi2f4n2+QkJFu3NCsBWYTh2nxTYMlS9Mjo9mH nwNbX1ghvBDvRiTUtY09Q/X1712d5i9o5UTax0lqHSXlWIEoocL1hCavEfInI+Nx+p MuAnR+pGry5gaSUOFRtBPrYD0CmLTc/0nHXXxAbE= X-ASG-Debug-ID: 1367003815-03d6a5737d01890001-1w8ZIA Received: from mail1.int.fusionio.com ([10.101.1.21]) by mx1.fusionio.com with ESMTP id 8MtjpCoNLCHcwA8m (version=TLSv1 cipher=AES128-SHA bits=128 verify=NO); Fri, 26 Apr 2013 13:16:55 -0600 (MDT) X-Barracuda-Envelope-From: JBacik@fusionio.com Received: from localhost (76.182.72.146) by mail.fusionio.com (10.101.1.19) with Microsoft SMTP Server (TLS) id 8.3.83.0; Fri, 26 Apr 2013 13:16:54 -0600 From: Josef Bacik To: , Subject: [PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs Date: Fri, 26 Apr 2013 15:16:53 -0400 X-ASG-Orig-Subj: [PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs Message-ID: <1367003813-17686-1-git-send-email-jbacik@fusionio.com> X-Mailer: git-send-email 1.7.7.6 MIME-Version: 1.0 X-Barracuda-Connect: UNKNOWN[10.101.1.21] X-Barracuda-Start-Time: 1367003815 X-Barracuda-Encrypted: AES128-SHA X-Barracuda-URL: http://10.101.1.180:8000/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at fusionio.com X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.129245 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org mkfs.ext4 will ask you if you are sure if you try to mkfs an entire disk instead of just a partition, so any xfstest that uses a scratch device and you specify a full disk will appear to hang because it's waiting for you to say yes. This fixes the problem by just forcing it to do its thing. Thanks, Signed-off-by: Josef Bacik Reviewed-by: Eric Sandeen --- common/rc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/rc b/common/rc index ff18cc2..9d1c3fc 100644 --- a/common/rc +++ b/common/rc @@ -485,7 +485,7 @@ _scratch_mkfs_ext4() { local tmp_dir=/tmp/ - /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV \ + /sbin/mkfs -t $FSTYP -- -F $MKFS_OPTIONS $* $SCRATCH_DEV \ 2>$tmp_dir.mkfserr 1>$tmp_dir.mkfsstd local mkfs_status=$?