From patchwork Fri Feb 1 10:43:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Czerner X-Patchwork-Id: 217419 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 875182C007A for ; Fri, 1 Feb 2013 21:45:15 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030201Ab3BAKox (ORCPT ); Fri, 1 Feb 2013 05:44:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18940 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756369Ab3BAKoc (ORCPT ); Fri, 1 Feb 2013 05:44:32 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r11AiUBu006188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Feb 2013 05:44:30 -0500 Received: from localhost.localdomain.com (vpn1-4-248.ams2.redhat.com [10.36.4.248]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r11AhkEC021563; Fri, 1 Feb 2013 05:44:28 -0500 From: Lukas Czerner To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, Lukas Czerner Subject: [PATCH 18/18] ext4: Allow punch hole with bigalloc enabled Date: Fri, 1 Feb 2013 11:43:44 +0100 Message-Id: <1359715424-32318-19-git-send-email-lczerner@redhat.com> In-Reply-To: <1359715424-32318-1-git-send-email-lczerner@redhat.com> References: <1359715424-32318-1-git-send-email-lczerner@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org In commits 5f95d21fb6f2aaa52830e5b7fb405f6c71d3ab85 and 30bc2ec9598a1b156ad75217f2e7d4560efdeeab we've reworked punch_hole implementation and there is noting holding us back from using punch hole on file system with bigalloc feature enabled. This has been tested with fsx and xfstests. Signed-off-by: Lukas Czerner --- fs/ext4/inode.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index e7bf594..01cf049 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3530,11 +3530,6 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length) return -EOPNOTSUPP; } - if (EXT4_SB(inode->i_sb)->s_cluster_ratio > 1) { - /* TODO: Add support for bigalloc file systems */ - return -EOPNOTSUPP; - } - return ext4_ext_punch_hole(file, offset, length); }