From patchwork Tue Mar 20 14:41:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Bityutskiy X-Patchwork-Id: 147801 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 91FCCB6EEF for ; Wed, 21 Mar 2012 01:43:58 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759809Ab2CTOlm (ORCPT ); Tue, 20 Mar 2012 10:41:42 -0400 Received: from mga01.intel.com ([192.55.52.88]:13019 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760235Ab2CTOlj (ORCPT ); Tue, 20 Mar 2012 10:41:39 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 20 Mar 2012 07:41:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="141907402" Received: from blue.fi.intel.com (HELO np.fi.intel.com) ([10.237.72.50]) by fmsmga002.fm.intel.com with ESMTP; 20 Mar 2012 07:41:16 -0700 From: Artem Bityutskiy To: Ted Tso Cc: Ext4 Mailing List , Linux FS Maling List , Linux Kernel Maling List , Al Viro Subject: [PATCH v1 5/9] VFS: remove unused superblock helpers Date: Tue, 20 Mar 2012 16:41:25 +0200 Message-Id: <1332254489-2300-6-git-send-email-dedekind1@gmail.com> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1332254489-2300-1-git-send-email-dedekind1@gmail.com> References: <1332254489-2300-1-git-send-email-dedekind1@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Artem Bityutskiy Remove the 'sb_mark_dirty()', 'sb_mark_clean()' and 'sb_is_dirty()' helpers which are not used. I introduced them 2 years and the intention was to make all file-systems use them in order to be able to optimize 'sync_supers()'. However, Al Viro vetoed my patches at the end and asked me to push superblock management down to file-systems and get rid of the 's_dirt' flag completely, as well as kill 'sync_supers()' altogether. Thus, remove the helpers. Signed-off-by: Artem Bityutskiy Cc: Al Viro --- include/linux/fs.h | 13 ------------- 1 files changed, 0 insertions(+), 13 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 69cd5bb..68387e9 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1870,19 +1870,6 @@ extern struct dentry *mount_pseudo(struct file_system_type *, char *, const struct dentry_operations *dops, unsigned long); -static inline void sb_mark_dirty(struct super_block *sb) -{ - sb->s_dirt = 1; -} -static inline void sb_mark_clean(struct super_block *sb) -{ - sb->s_dirt = 0; -} -static inline int sb_is_dirty(struct super_block *sb) -{ - return sb->s_dirt; -} - /* Alas, no aliases. Too much hassle with bringing module.h everywhere */ #define fops_get(fops) \ (((fops) && try_module_get((fops)->owner) ? (fops) : NULL))