From patchwork Tue Jun 28 11:26:03 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Czerner X-Patchwork-Id: 102355 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 05111B6F6C for ; Tue, 28 Jun 2011 21:38:03 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756660Ab1F1L1A (ORCPT ); Tue, 28 Jun 2011 07:27:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36661 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757320Ab1F1L0U (ORCPT ); Tue, 28 Jun 2011 07:26:20 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5SBQ7Wt028010 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 28 Jun 2011 07:26:07 -0400 Received: from dhcp-27-109.brq.redhat.com (dhcp-1-248.brq.redhat.com [10.34.1.248]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5SBQ5e0012575; Tue, 28 Jun 2011 07:26:05 -0400 From: Lukas Czerner To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, jack@suse.cz, sandeen@redhat.com, adilger@dilger.ca, Lukas Czerner Subject: [PATCH v2] ext4: Deprecate data=journal mount option Date: Tue, 28 Jun 2011 13:26:03 +0200 Message-Id: <1309260363-19012-1-git-send-email-lczerner@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Data journalling mode (data=journal) is known to be neglected by developers and only minority of people is actually using it. This mode is also less tested than the other two modes by the developers. This creates a dangerous combination, because the option which seems *safer* is actually less safe the others. So this commit adds a warning message in case that data=journal mode is used, so the user is informed that the mode might be removed in the future. Signed-off-by: Lukas Czerner --- fs/ext4/super.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 9ea71aa..9d189cf 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1631,6 +1631,11 @@ static int parse_options(char *options, struct super_block *sb, sbi->s_min_batch_time = option; break; case Opt_data_journal: + ext4_msg(sb, KERN_WARNING, + "Using data=journal may be removed in the " + "future. Please, contact " + "linux-ext4@vger.kernel.org if you are " + "using this feature."); data_opt = EXT4_MOUNT_JOURNAL_DATA; goto datacheck; case Opt_data_ordered: