From patchwork Wed Jun 1 14:34:04 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 98199 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 34719B6F81 for ; Thu, 2 Jun 2011 00:33:39 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757399Ab1FAOdQ (ORCPT ); Wed, 1 Jun 2011 10:33:16 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:36536 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756766Ab1FAOdN (ORCPT ); Wed, 1 Jun 2011 10:33:13 -0400 Received: by pvg12 with SMTP id 12so2545583pvg.19 for ; Wed, 01 Jun 2011 07:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer; bh=J19AXAF5SB9VqAiyP6+sM1QCSji8liRmkzQWaZCyjZQ=; b=nmewtnAXtBEC8gitj8ZXUXEF168vmM6oDWl6u8MZ/J9FpdB7D3EZiGNfjbZrsprcjC Om5GiaJ4b9A/cHxeQlUjloEI62xAu+dAOLAYMV/r1Nppx3gAGTUJzsxjlGqbePbS3Ij8 0riAymQlGPX4jj4lusfqqG1r571dMuhspNxBo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=sycBoCIpqUrlnox4LaabWwtC6xGBYqbYU1IkQYk2VwkboqD1tpC/rAeJRTRH3ZXTZV lNFKqDDWMOWcd9baqcFdzaDWbmSufMk4SNOreqT7Xl0LcMx4kjL+GpOx8ilVlMsNIez3 2oxL41f20jf7ptDY0xR3YRrDGj1haU4wjJdJc= Received: by 10.68.59.106 with SMTP id y10mr2605854pbq.51.1306938792936; Wed, 01 Jun 2011 07:33:12 -0700 (PDT) Received: from localhost.localdomain (p10026-adsao02yokonib2-acca.kanagawa.ocn.ne.jp [219.161.42.26]) by mx.google.com with ESMTPS id x1sm1122742pbb.18.2011.06.01.07.33.10 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 01 Jun 2011 07:33:12 -0700 (PDT) From: Akinobu Mita To: linux-kernel@vger.kernel.org Cc: Akinobu Mita , Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org Subject: [PATCH v2] ext3: use proper little-endian bitops Date: Wed, 1 Jun 2011 23:34:04 +0900 Message-Id: <1306938844-11178-1-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org ext3_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le() for ext3. But all ext3_{set,clear}_bit() calls ignore return values. So these can be replaced with __{set,clear}_bit_le(). This changes ext3_{set,clear}_bit safely, because if someone uses these macros without noticing the change, new ext3_{set,clear}_bit don't have return value and causes compiler errors where the return value is used. This also removes unused ext3_find_first_zero_bit(). Signed-off-by: Akinobu Mita Cc: Jan Kara Cc: Andrew Morton Cc: Andreas Dilger Cc: linux-ext4@vger.kernel.org --- v2: rewritten to keep ext3_*_bit() macros include/linux/ext3_fs.h | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/linux/ext3_fs.h b/include/linux/ext3_fs.h index 5e06acf..50f21ee 100644 --- a/include/linux/ext3_fs.h +++ b/include/linux/ext3_fs.h @@ -418,12 +418,11 @@ struct ext3_inode { #define EXT2_MOUNT_DATA_FLAGS EXT3_MOUNT_DATA_FLAGS #endif -#define ext3_set_bit __test_and_set_bit_le +#define ext3_set_bit __set_bit_le #define ext3_set_bit_atomic ext2_set_bit_atomic -#define ext3_clear_bit __test_and_clear_bit_le +#define ext3_clear_bit __clear_bit_le #define ext3_clear_bit_atomic ext2_clear_bit_atomic #define ext3_test_bit test_bit_le -#define ext3_find_first_zero_bit find_first_zero_bit_le #define ext3_find_next_zero_bit find_next_zero_bit_le /*