From patchwork Sun Aug 2 11:43:23 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Tao X-Patchwork-Id: 30472 Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 82373B7B6A for ; Sun, 2 Aug 2009 21:43:37 +1000 (EST) Received: by ozlabs.org (Postfix) id 6FDA5DDDA2; Sun, 2 Aug 2009 21:43:37 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 05428DDD1B for ; Sun, 2 Aug 2009 21:43:36 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751137AbZHBLne (ORCPT ); Sun, 2 Aug 2009 07:43:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752444AbZHBLnd (ORCPT ); Sun, 2 Aug 2009 07:43:33 -0400 Received: from mail-pz0-f200.google.com ([209.85.222.200]:37047 "EHLO mail-pz0-f200.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbZHBLnd (ORCPT ); Sun, 2 Aug 2009 07:43:33 -0400 Received: by pzk38 with SMTP id 38so1735571pzk.33 for ; Sun, 02 Aug 2009 04:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=x/triMTR/HM4YuukTpPS5cfDgTRjTECJ4jX9P+I7bQ0=; b=GXAIhIfM1oIl699eAX76jvBLvFcVauzKuREEalYq/d8VAnaB/JsNhWJHClUpPBfNnQ mh0SIwAetF+UY7pH77a8s5tMj5Ygan5GCPRkyrD9wIzIWGufIDihlAxzpPAI+uigdNxJ /QNmwwhk3ReOhJ9vyHev8fY5oaSXGhAjC3Meo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=lLH3aUY603X1dNW+Dx2wPcrlCY8cOsM0fXM6bLXtJAjEJF08p2DQ8Y9qQ8zIXvv0ST QeRHcVI36iORt/LotsR9rIOtf4CQzgknLQWTtx8a8ptpeivGZ4jo8n61Axp5pM/wM7To e18iSPlbtsQ904pKDT14eI37mYbGFM/rBh+zo= Received: by 10.115.22.11 with SMTP id z11mr3152153wai.156.1249213413734; Sun, 02 Aug 2009 04:43:33 -0700 (PDT) Received: from localhost.localdomain ([59.64.158.44]) by mx.google.com with ESMTPS id j26sm8681700waf.63.2009.08.02.04.43.31 (version=SSLv3 cipher=RC4-MD5); Sun, 02 Aug 2009 04:43:33 -0700 (PDT) From: Peng Tao To: linux-ext4@vger.kernel.org Cc: Theodore Ts'o , Akira Fujita Subject: [PATCH 1/2] ext4: fix journal ref count in move_extent_par_page Date: Sun, 2 Aug 2009 19:43:23 +0800 Message-Id: <1249213404-6277-1-git-send-email-bergwolf@gmail.com> X-Mailer: git-send-email 1.6.2.GIT Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org move_extent_par_page calls a_ops->write_begin() to increase journal handler's reference count. However, if either mext_replace_branches() or ext4_get_block fails, the increased reference count isn't decreased. This will cause later umounting of the fs forever hangs. The patch addresses the issue by calling ext4_journal_stop() if page is not NULL (which means a_ops->write_end() isn't invoked). Signed-off-by: Peng Tao --- fs/ext4/move_extent.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index bbf2dd9..5821e0b 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -871,6 +871,7 @@ out: if (PageLocked(page)) unlock_page(page); page_cache_release(page); + ext4_journal_stop(handle); } out2: ext4_journal_stop(handle);