From patchwork Fri Apr 3 07:01:07 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theodore Ts'o X-Patchwork-Id: 25562 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 88A84DDDA2 for ; Fri, 3 Apr 2009 18:01:16 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754454AbZDCHBO (ORCPT ); Fri, 3 Apr 2009 03:01:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754002AbZDCHBN (ORCPT ); Fri, 3 Apr 2009 03:01:13 -0400 Received: from thunk.org ([69.25.196.29]:36445 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbZDCHBL (ORCPT ); Fri, 3 Apr 2009 03:01:11 -0400 Received: from root (helo=closure.thunk.org) by thunker.thunk.org with local-esmtp (Exim 4.50 #1 (Debian)) id 1LpdOm-0008O7-Vq; Fri, 03 Apr 2009 03:01:09 -0400 Received: from tytso by closure.thunk.org with local (Exim 4.69) (envelope-from ) id 1LpdOl-0008Dr-MY; Fri, 03 Apr 2009 03:01:07 -0400 From: Theodore Ts'o To: torvalds@linuxfoundation.org Cc: Linux Kernel Developers List , Ext4 Developers List , Theodore Ts'o Subject: [PATCH 4/4] ext3: Add replace-on-rename hueristics for data=writeback mode Date: Fri, 3 Apr 2009 03:01:07 -0400 Message-Id: <1238742067-30814-5-git-send-email-tytso@mit.edu> X-Mailer: git-send-email 1.5.6.3 In-Reply-To: <1238742067-30814-4-git-send-email-tytso@mit.edu> References: <1238742067-30814-1-git-send-email-tytso@mit.edu> <1238742067-30814-2-git-send-email-tytso@mit.edu> <1238742067-30814-3-git-send-email-tytso@mit.edu> <1238742067-30814-4-git-send-email-tytso@mit.edu> X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@mit.edu X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org In data=writeback mode, start an asynchronous flush when renaming a file on top of an already-existing file. This lowers the probability of data loss in the case of applications that attempt to replace a file via using rename(). Signed-off-by: "Theodore Ts'o" --- fs/ext3/namei.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c index 4db4ffa..ab98a66 100644 --- a/fs/ext3/namei.c +++ b/fs/ext3/namei.c @@ -2265,7 +2265,7 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry, struct inode * old_inode, * new_inode; struct buffer_head * old_bh, * new_bh, * dir_bh; struct ext3_dir_entry_2 * old_de, * new_de; - int retval; + int retval, flush_file = 0; old_bh = new_bh = dir_bh = NULL; @@ -2401,6 +2401,8 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry, ext3_mark_inode_dirty(handle, new_inode); if (!new_inode->i_nlink) ext3_orphan_add(handle, new_inode); + if (ext3_should_writeback_data(new_inode)) + flush_file = 1; } retval = 0; @@ -2409,6 +2411,8 @@ end_rename: brelse (old_bh); brelse (new_bh); ext3_journal_stop(handle); + if (retval == 0 && flush_file) + filemap_flush(old_inode->i_mapping); return retval; }