From patchwork Tue Jan 13 12:42:02 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kara X-Patchwork-Id: 18220 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 0E9E2DE2B3 for ; Tue, 13 Jan 2009 23:42:07 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754007AbZAMMmG (ORCPT ); Tue, 13 Jan 2009 07:42:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754929AbZAMMmF (ORCPT ); Tue, 13 Jan 2009 07:42:05 -0500 Received: from styx.suse.cz ([82.119.242.94]:58005 "EHLO mail.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754007AbZAMMmD (ORCPT ); Tue, 13 Jan 2009 07:42:03 -0500 Received: from duck.suse.cz (duck.suse.cz [10.20.1.74]) by mail.suse.cz (Postfix) with ESMTP id 478EC628402; Tue, 13 Jan 2009 13:42:02 +0100 (CET) Received: by duck.suse.cz (Postfix, from userid 10005) id 301ED1F1E2A; Tue, 13 Jan 2009 13:42:02 +0100 (CET) From: Jan Kara To: linux-ext4@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , Jan Kara , Pavel Machek Subject: [PATCH] ext2: Update also inode on disk when dir is IS_DIRSYNC Date: Tue, 13 Jan 2009 13:42:02 +0100 Message-Id: <1231850522-11074-1-git-send-email-jack@suse.cz> X-Mailer: git-send-email 1.6.0.2 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org We used to just write changed page for IS_DIRSYNC inodes. But we also have to update directory inode itself just for the case that we've allocated a new block and changed i_size. Signed-off-by: Jan Kara CC: Pavel Machek --- fs/ext2/dir.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) Andrew, would you please merge the patch? Ext3 and ext4 don't have this problem BTW. diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c index 9a0fc40..7fba549 100644 --- a/fs/ext2/dir.c +++ b/fs/ext2/dir.c @@ -94,11 +94,10 @@ static int ext2_commit_chunk(struct page *page, loff_t pos, unsigned len) i_size_write(dir, pos+len); mark_inode_dirty(dir); } + unlock_page(page); if (IS_DIRSYNC(dir)) - err = write_one_page(page, 1); - else - unlock_page(page); + err = ext2_sync_inode(dir); return err; }