From patchwork Mon Dec 1 13:43:46 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aneesh Kumar K.V" X-Patchwork-Id: 11585 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 49BC6DDDE6 for ; Tue, 2 Dec 2008 00:44:06 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751555AbYLANoD (ORCPT ); Mon, 1 Dec 2008 08:44:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751746AbYLANoD (ORCPT ); Mon, 1 Dec 2008 08:44:03 -0500 Received: from e28smtp06.in.ibm.com ([59.145.155.6]:54106 "EHLO e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbYLANoA (ORCPT ); Mon, 1 Dec 2008 08:44:00 -0500 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by e28smtp06.in.ibm.com (8.13.1/8.13.1) with ESMTP id mB1DhwCJ010564 for ; Mon, 1 Dec 2008 19:13:58 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mB1Dhxm61187996 for ; Mon, 1 Dec 2008 19:13:59 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.13.1/8.13.3) with ESMTP id mB1DhugW015953 for ; Tue, 2 Dec 2008 00:43:57 +1100 Received: from localhost.localdomain ([9.77.199.175]) by d28av05.in.ibm.com (8.13.1/8.12.11) with ESMTP id mB1DhmP8015817; Tue, 2 Dec 2008 00:43:54 +1100 From: "Aneesh Kumar K.V" To: cmm@us.ibm.com, tytso@mit.edu, sandeen@redhat.com Cc: linux-ext4@vger.kernel.org, "Aneesh Kumar K.V" Subject: [PATCH -V2 4/4] ext4: Init the complete page while building buddy cache Date: Mon, 1 Dec 2008 19:13:46 +0530 Message-Id: <1228139026-22736-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com> X-Mailer: git-send-email 1.6.0.4.735.gea4f In-Reply-To: <1228139026-22736-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1228139026-22736-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1228139026-22736-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1228139026-22736-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org We need to init the complete page during buddy cache init by setting the contents to '1'. This ensures that during resize when we increment the s_groups_count we don't hit the erros as below. EXT4-fs error (device sdb1): ext4_mb_mark_diskspace_used: Allocating block 1040385 in system zone of 127 group Signed-off-by: Aneesh Kumar K.V --- fs/ext4/mballoc.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 8f33691..01c86f3 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -846,6 +846,8 @@ static int ext4_mb_init_cache(struct page *page, char *incore) err = 0; first_block = page->index * blocks_per_page; + /* init the page */ + memset(page_address(page), 0xff, PAGE_CACHE_SIZE); for (i = 0; i < blocks_per_page; i++) { int group; struct ext4_group_info *grinfo;