| Message ID | 1223566329-29434-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Thu, Oct 09, 2008 at 09:02:08PM +0530, Aneesh Kumar K.V wrote: > We need to make sure we don't reuse the data blocks released > during the transaction untill the transaction commits. We force > this mode only for ordered and journalled mode. Writeback mode > already don't provided data consistency. It might be a good idea in ext4_free_mb_metadata() to add a comment that the name of the function is a little bit of a misnomer... BTW, you may want to check what I put in the patch queue, because iirc, I fixed up a few spelling/grammar in the patch comments. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index bd2ece2..b9821be 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c @@ -568,8 +568,16 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode, /* this isn't the right place to decide whether block is metadata * inode.c/extents.c knows better, but for safety ... */ - if (S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode) || - ext4_should_journal_data(inode)) + if (S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode)) + metadata = 1; + + /* We need to make sure we don't reuse + * block released untill the transaction commit. + * writeback mode have weak data consistency so + * don't force data as metadata when freeing block + * for writeback mode. + */ + if (metadata == 0 && !ext4_should_writeback_data(inode)) metadata = 1; sb = inode->i_sb;
We need to make sure we don't reuse the data blocks released during the transaction untill the transaction commits. We force this mode only for ordered and journalled mode. Writeback mode already don't provided data consistency. Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> --- fs/ext4/balloc.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-)