diff mbox series

[031/141] ext4: Fix fall-through warnings for Clang

Message ID 03497331f088a938d7a728e7a689bd7953139429.1605896059.git.gustavoars@kernel.org
State Awaiting Upstream
Headers show
Series Fix fall-through warnings for Clang | expand

Commit Message

Gustavo A. R. Silva Nov. 20, 2020, 6:28 p.m. UTC 
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 fs/ext4/super.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Theodore Ts'o Dec. 17, 2020, 3:47 a.m. UTC | #1 
On Fri, Nov 20, 2020 at 12:28:32PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Thanks, applied.

					- Ted
diff mbox series

Patch

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 6633b20224d5..ca04389fc718 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4877,6 +4877,7 @@  static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 			       "requested data journaling mode");
 			goto failed_mount_wq;
 		}
+		break;
 	default:
 		break;
 	}