mbox series

[RFC,00/16] ext4: mballoc/extents: Code cleanup and debug improvements

Message ID cover.1589086800.git.riteshh@linux.ibm.com
Headers show
Series ext4: mballoc/extents: Code cleanup and debug improvements | expand

Message

Ritesh Harjani May 10, 2020, 6:24 a.m. UTC
Hello All,

This series does some code refactoring/cleanups and debug logs improvements
around mb_debug() and ext_debug(). These were found when working over
improving mballoc ENOSPC handling in ext4.
These should be small and stright forward patches for reviewing.

Ritesh Harjani (16):
  ext4: mballoc: Do print bb_free info even when it is 0
  ext4: mballoc: Refactor ext4_mb_show_ac()
  ext4: mballoc: Add more mb_debug() msgs
  ext4: mballoc: Correct the mb_debug() format specifier for pa_len var
  ext4: mballoc: Fix few other format specifier in mb_debug()
  ext4: mballoc: Simplify error handling in ext4_init_mballoc()
  ext4: mballoc: Make ext4_mb_use_preallocated() return type as bool
  ext4: mballoc: Refactor code inside DOUBLE_CHECK into separate function
  ext4: mballoc: Fix possible NULL ptr & remove BUG_ONs from DOUBLE_CHECK
  ext4: balloc: Use task_pid_nr() helper
  ext4: Use BIT() macro for BH_** state bits
  ext4: Improve ext_debug() msg in case of block allocation failure
  ext4: Replace EXT_DEBUG with __maybe_unused in ext4_ext_handle_unwritten_extents()
  ext4: mballoc: Make mb_debug() implementation to use pr_debug()
  ext4: Make ext_debug() implementation to use pr_debug()
  ext4: Add process name and pid in ext4_msg()

 fs/ext4/Kconfig   |   3 +-
 fs/ext4/balloc.c  |   5 +-
 fs/ext4/ext4.h    |  26 +++--
 fs/ext4/extents.c | 150 +++++++++++++-------------
 fs/ext4/inode.c   |  15 +--
 fs/ext4/mballoc.c | 265 ++++++++++++++++++++++++++--------------------
 fs/ext4/mballoc.h |  16 ++-
 fs/ext4/super.c   |   3 +-
 8 files changed, 261 insertions(+), 222 deletions(-)

Comments

Theodore Y. Ts'o May 28, 2020, 2:20 p.m. UTC | #1
On Sun, May 10, 2020 at 11:54:40AM +0530, Ritesh Harjani wrote:
> Hello All,
> 
> This series does some code refactoring/cleanups and debug logs improvements
> around mb_debug() and ext_debug(). These were found when working over
> improving mballoc ENOSPC handling in ext4.
> These should be small and stright forward patches for reviewing.

I've applied all but the last patch ("Add process namd and pid in
ext4_msg"), which I think needs a bit more discussion.

	    	    	  	      - Ted