mbox series

[0/2] ext4: Do not let fstrim block suspend

Message ID 20230913145649.3595-1-jack@suse.cz
Headers show
Series ext4: Do not let fstrim block suspend | expand

Message

Jan Kara Sept. 13, 2023, 3:04 p.m. UTC
Hello,

these two patches fix a long standing issue that long running fstrim request
can block a system suspend as reported by Len Brown in [1]. The solution is
quite simple - just report whatever we have trimmed upto now since discard
is an advisory call anyway. What makes things a bit more complex is handling
of group's TRIMMED bit - we deal with that in patch 1.

								Honza

[1] https://bugzilla.kernel.org/show_bug.cgi?id=216322

Comments

Theodore Ts'o Sept. 14, 2023, 3 p.m. UTC | #1
On Wed, 13 Sep 2023 17:04:53 +0200, Jan Kara wrote:
> these two patches fix a long standing issue that long running fstrim request
> can block a system suspend as reported by Len Brown in [1]. The solution is
> quite simple - just report whatever we have trimmed upto now since discard
> is an advisory call anyway. What makes things a bit more complex is handling
> of group's TRIMMED bit - we deal with that in patch 1.
> 
> 								Honza
> 
> [...]

Applied, thanks!

[1/2] ext4: Move setting of trimmed bit into ext4_try_to_trim_range()
      commit: 5e4a9f11b5d7cb70a4e4474f0ba25d5f1fd2a8ed
[2/2] ext4: Do not let fstrim block system suspend
      commit: b016ebb300e514bc46151f8fc006caae141a8bde

Best regards,