| Message ID | 20230606135928.434610-1-yi.zhang@huaweicloud.com |
|---|---|
| Headers | show |
| Series | jbd2: fix several checkpoint inconsistent issues | expand |
On Tue, 06 Jun 2023 21:59:22 +0800, Zhang Yi wrote: > v2->v3: > - Init released parameter in journal_shrink_one_cp_list() instead of > __jbd2_journal_clean_checkpoint_list() in patch 3. > - Fix a comment in patch 5. > v1->v2: > - Drop the last patch in [1]. > - Merge journal_clean_one_cp_list() into journal_shrink_one_cp_list(). > - Fix the race issues through trying to hold buffer lock and check > dirty state under the lock. > - Append a cleanup patch, remove __journal_try_to_free_buffer(). > > [...] Applied, thanks! [1/6] jbd2: recheck chechpointing non-dirty buffer commit: c2d6fd9d6f35079f1669f0100f05b46708c74b7f [2/6] jbd2: remove t_checkpoint_io_list commit: be22255360f80d3af789daad00025171a65424a5 [3/6] jbd2: remove journal_clean_one_cp_list() commit: b98dba273a0e47dbfade89c9af73c5b012a4eabb [4/6] jbd2: Fix wrongly judgement for buffer head removing while doing checkpoint commit: e34c8dd238d0c9368b746480f313055f5bab5040 [5/6] jbd2: fix a race when checking checkpoint buffer busy commit: 46f881b5b1758dc4a35fba4a643c10717d0cf427 [6/6] jbd2: remove __journal_try_to_free_buffer() commit: 3c55097c553c49deab60ac62c83ef17565004a97 Best regards,
From: Zhang Yi <yi.zhang@huawei.com> v2->v3: - Init released parameter in journal_shrink_one_cp_list() instead of __jbd2_journal_clean_checkpoint_list() in patch 3. - Fix a comment in patch 5. v1->v2: - Drop the last patch in [1]. - Merge journal_clean_one_cp_list() into journal_shrink_one_cp_list(). - Fix the race issues through trying to hold buffer lock and check dirty state under the lock. - Append a cleanup patch, remove __journal_try_to_free_buffer(). Hello, The first two patches are from [1] and are not changed, appending another four (it depends on the first three) to fix another three race issues in the checkpoint procedure which could also lead to inconsistent results. [1] https://lore.kernel.org/linux-ext4/20230516020226.2813588-1-yi.zhang@huaweicloud.com/ Thanks, Yi. Zhang Yi (5): jbd2: recheck chechpointing non-dirty buffer jbd2: remove t_checkpoint_io_list jbd2: remove journal_clean_one_cp_list() jbd2: fix a race when checking checkpoint buffer busy jbd2: remove __journal_try_to_free_buffer() Zhihao Cheng (1): jbd2: Fix wrongly judgement for buffer head removing while doing checkpoint fs/jbd2/checkpoint.c | 277 ++++++++++++------------------------ fs/jbd2/commit.c | 3 +- fs/jbd2/transaction.c | 40 ++---- include/linux/jbd2.h | 7 +- include/trace/events/jbd2.h | 12 +- 5 files changed, 108 insertions(+), 231 deletions(-)