From patchwork Mon Jan 10 04:48:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xin Yin X-Patchwork-Id: 1577761 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bytedance-com.20210112.gappssmtp.com header.i=@bytedance-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=JPgqoymj; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JXLwN3Wf8z9sRR for ; Mon, 10 Jan 2022 15:49:56 +1100 (AEDT) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4JXLwL6N3Zz4xmx for ; Mon, 10 Jan 2022 15:49:54 +1100 (AEDT) Received: by gandalf.ozlabs.org (Postfix) id 4JXLwL6DrCz4xtf; Mon, 10 Jan 2022 15:49:54 +1100 (AEDT) Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: gandalf.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: gandalf.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bytedance-com.20210112.gappssmtp.com header.i=@bytedance-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=JPgqoymj; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4JXLwL68whz4xmx for ; Mon, 10 Jan 2022 15:49:54 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233084AbiAJEtu (ORCPT ); Sun, 9 Jan 2022 23:49:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232966AbiAJEtt (ORCPT ); Sun, 9 Jan 2022 23:49:49 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7648BC06173F for ; Sun, 9 Jan 2022 20:49:49 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id n16so10906295plc.2 for ; Sun, 09 Jan 2022 20:49:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bD6zeuVgCTlq+zfvzqfbER3EToA3lGW10eCyIwR7cYs=; b=JPgqoymjnTLcVojp7IBqhEkpgLAAh12doBI8Kjrr7fIyM8ed5YNQk5Q6ssDDfBpg7f MUiuesoz3dNkIPSicQzTTqGZL4KUpv2xiDlUYAbgWKj8mIZ0U+FVDmEl2q0IKCCi2gGs 2olwFAiCrxmtugIl0H5eBHs+KrJPp0Yo+IgbxL63W/QS4hW6kGJ23+/T4KKjag9ZCq9p Y8NMYyGZ+dG2dIX22ZUxiUC+/XL4CKp+6MElo8iAR7iJo4HC9rcw8p77w6aVa6zeU3+5 RGXE0glCkMT17U8sWGRX9bBRCAvAnAJybMgKh47vWZmhjdmcDiOQrv7MthTKanm1sWhy OkBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bD6zeuVgCTlq+zfvzqfbER3EToA3lGW10eCyIwR7cYs=; b=W+uiOZw/qzPwfiTOkrN5XYvs7Kbc7UTvQXMkkBmQyXvZk/17le5WbeDhuTVJsFScjP uIChgkoVEXK6FTSaTyo7oV6gxTwUaM0wkL/Bwt0hKHv0Kj+TSaY2HxoquJRa348VCFA5 vaXaw4YpRa67fFxdxBnmDq0aWSuS+9uUF+USFC3zI/m6ovit6S46mrRy76t6O0QPO27Q I8GCCasQgefh0cPA95Jqjaxe+bJFkK1JF+//nPMYXfKWFQ/llSbO0drLgW5MkJfTu73G TS7VL6tw/YpX8DOLG3J3HFx+Dlzb/WIsx3NqCRZgT7POMz7Ei5NDqZw7XKIJEBIbz1yV yz/A== X-Gm-Message-State: AOAM531gguco1IvY48TTt4vpkS8Bfz6QF/7i9mq1EBsICL80gdN3Pm1a Xpl/Kfb7Z6u7fq6GHwOoCAfwMA== X-Google-Smtp-Source: ABdhPJyV4hGH1n9h4eT5F4wnM1l0eR0t92pPMOPG8ztoW+eH1xdPBj7qfCW1cv+3dETT5Q89jluqGg== X-Received: by 2002:a17:90a:ae17:: with SMTP id t23mr4668243pjq.116.1641790189022; Sun, 09 Jan 2022 20:49:49 -0800 (PST) Received: from yinxin.bytedance.net ([139.177.225.251]) by smtp.gmail.com with ESMTPSA id v8sm5449997pfu.68.2022.01.09.20.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jan 2022 20:49:48 -0800 (PST) From: Xin Yin To: harshadshirwadkar@gmail.com, tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Xin Yin Subject: [PATCH v2 0/2] ext4: fix issues when fast commit work with jbd Date: Mon, 10 Jan 2022 12:48:47 +0800 Message-Id: <20220110044850.2806-1-yinxin.x@bytedance.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org When test fast commit with xfstests generic/455, some logic issues were found. When a full commit is ongonig, the logic of fast commit tracking seems not correct. The first patch fix the ineligible commit case , and the second patch fix the common fast commit case. After testing this patch set with xfstests log and quick group, no regressions were found, and the generic/455 can pass now. --- v2: drop EXT4_MF_FC_COMMITTING Xin Yin (2): ext4: fast commit may not fallback for ineligible commit ext4: fast commit may miss file actions fs/ext4/ext4.h | 3 ++- fs/ext4/extents.c | 4 ++-- fs/ext4/fast_commit.c | 28 +++++++++++++++++++--------- fs/ext4/inode.c | 4 ++-- fs/ext4/ioctl.c | 4 ++-- fs/ext4/namei.c | 4 ++-- fs/ext4/super.c | 1 + fs/ext4/xattr.c | 6 +++--- fs/jbd2/commit.c | 2 +- fs/jbd2/journal.c | 2 +- include/linux/jbd2.h | 2 +- 11 files changed, 36 insertions(+), 24 deletions(-)