mbox series

[0/4] ext4: clean up ext4_ext_handle_unwritten_extents()

Message ID 20200430185320.23001-1-enwlinux@gmail.com
Headers show
Series ext4: clean up ext4_ext_handle_unwritten_extents() | expand

Message

Eric Whitney April 30, 2020, 6:53 p.m. UTC 
Changes made to ext4 over time have resulted in some cruft accumulating
in ext4_ext_handle_unwritten_extents().  This patch series removes
some dead and some redundant code, simplifies and corrects some error
handling, and adds explicit error logging when an unexpected internal
error or file system corruption may have occurred.

Eric Whitney (4):
  ext4: remove dead GET_BLOCKS_ZERO code
  ext4: remove redundant GET_BLOCKS_CONVERT code
  ext4: clean up GET_BLOCKS_PRE_IO error handling
  ext4: clean up ext4_ext_convert_to_initialized() error handling

 fs/ext4/extents.c | 81 ++++++++++++++++++++++++++---------------------
 1 file changed, 45 insertions(+), 36 deletions(-)

Comments

Theodore Ts'o May 21, 2020, 2:59 p.m. UTC | #1 
On Thu, Apr 30, 2020 at 02:53:16PM -0400, Eric Whitney wrote:
> Changes made to ext4 over time have resulted in some cruft accumulating
> in ext4_ext_handle_unwritten_extents().  This patch series removes
> some dead and some redundant code, simplifies and corrects some error
> handling, and adds explicit error logging when an unexpected internal
> error or file system corruption may have occurred.
> 
> Eric Whitney (4):
>   ext4: remove dead GET_BLOCKS_ZERO code
>   ext4: remove redundant GET_BLOCKS_CONVERT code
>   ext4: clean up GET_BLOCKS_PRE_IO error handling
>   ext4: clean up ext4_ext_convert_to_initialized() error handling
> 
>  fs/ext4/extents.c | 81 ++++++++++++++++++++++++++---------------------
>  1 file changed, 45 insertions(+), 36 deletions(-)

Thanks, I've applied this patch series.

						- Ted