Message ID | 20181116083737.10596-1-devel@etsukata.com |
---|---|
Headers | show |
Series | fs: fix race between llseek SEEK_END and write | expand |
> I would like to ask you the following questions; > > Q1. Do you consider this behavior as a bug in kernel? > or userspace applications are responseible for it? Yes I would consider it a bug. > > Q2. If it is a bug, how should we fix it? > > Currently I'm planning to re-introduce generic_file_llseek_unlocked() > and inode lock in generic_file_llseek() for SEEK_END. Then replace > generic_file_llseek() with generic_file_llseek_unlocked() if it called > with inode lock in individual file systems. Please let me know if the > way is not appropreate or any other better way to fix it. Sounds reasonable. -Andi
> > > > Q2. If it is a bug, how should we fix it? > > > > Currently I'm planning to re-introduce generic_file_llseek_unlocked() > > and inode lock in generic_file_llseek() for SEEK_END. Then replace > > generic_file_llseek() with generic_file_llseek_unlocked() if it called > > with inode lock in individual file systems. Please let me know if the > > way is not appropreate or any other better way to fix it. > > Sounds reasonable. > > -Andi Thanks for comments. I'll make a patch. Eiichi