| Message ID | 00ad4a90-8a40-24c1-98d9-eb5f0da42436@huawei.com |
|---|---|
| Headers | show |
| Series | e2fsprogs: some bugfixs and some code cleanups | expand |
On Mon, May 31, 2021 at 09:23:49AM +0800, Wu Guanghao wrote: > V1 -> V2: > > [PATCH V2 03/12] zap_sector: fix memory leak > free and return operators placed in {} block > > [PATCH V2 04/12] ss_add_info_dir: fix memory leak and check whether,NULL pointer > modified "=" to "==" > > [PATCH V2 06/12] append_pathname: check the value returned by realloc to avoid segfault > [PATCH V2 07/12] argv_parse: check return value of malloc in argv_parse() > Fix typos > > [PATCH V2 10/12] hashmap: change return value type of, ext2fs_hashmap_add() > remove "new_block = NULL;" Did you only send the patches that you changed, and didn't resend the patches that didn't change between V1 and V2? It's actually better if you resend the whole series in the future. Thanks, - Ted
Hello Ted, Thank you for your advice, I will pay attention to it in the future. Do I need to resend the series of patches or continue to send the remaining patches this time? Thanks, Wu Guanghao On Mon, 31 May 2021 00:28:46 -0400, Theodore Ts'o wrote: > > > > On Mon, May 31, 2021 at 09:23:49AM +0800, Wu Guanghao wrote: >> V1 -> V2: >> >> [PATCH V2 03/12] zap_sector: fix memory leak >> free and return operators placed in {} block >> >> [PATCH V2 04/12] ss_add_info_dir: fix memory leak and check whether,NULL pointer >> modified "=" to "==" >> >> [PATCH V2 06/12] append_pathname: check the value returned by realloc to avoid segfault >> [PATCH V2 07/12] argv_parse: check return value of malloc in argv_parse() >> Fix typos >> >> [PATCH V2 10/12] hashmap: change return value type of, ext2fs_hashmap_add() >> remove "new_block = NULL;" > > Did you only send the patches that you changed, and didn't resend the > patches that didn't change between V1 and V2? > > It's actually better if you resend the whole series in the future. > > Thanks, > > - Ted > . > .
friendly ping... What is the current status of the patch set？ On 2021/5/31 12:28, Theodore Ts'o wrote: > On Mon, May 31, 2021 at 09:23:49AM +0800, Wu Guanghao wrote: >> V1 -> V2: >> >> [PATCH V2 03/12] zap_sector: fix memory leak >> free and return operators placed in {} block >> >> [PATCH V2 04/12] ss_add_info_dir: fix memory leak and check whether,NULL pointer >> modified "=" to "==" >> >> [PATCH V2 06/12] append_pathname: check the value returned by realloc to avoid segfault >> [PATCH V2 07/12] argv_parse: check return value of malloc in argv_parse() >> Fix typos >> >> [PATCH V2 10/12] hashmap: change return value type of, ext2fs_hashmap_add() >> remove "new_block = NULL;" > Did you only send the patches that you changed, and didn't resend the > patches that didn't change between V1 and V2? > > It's actually better if you resend the whole series in the future. > > Thanks, > > - Ted > > .
V1 -> V2: [PATCH V2 03/12] zap_sector: fix memory leak free and return operators placed in {} block [PATCH V2 04/12] ss_add_info_dir: fix memory leak and check whether,NULL pointer modified "=" to "==" [PATCH V2 06/12] append_pathname: check the value returned by realloc to avoid segfault [PATCH V2 07/12] argv_parse: check return value of malloc in argv_parse() Fix typos [PATCH V2 10/12] hashmap: change return value type of, ext2fs_hashmap_add() remove "new_block = NULL;" Zhiqiang Liu (6): misc: fix potential segmentation fault problem in scandir() lib/ss/error.c: check return value malloc in ss_name() hashmap: change return value type of ext2fs_hashmap_add() misc/lsattr: check whether path is NULL in lsattr_dir_proc() ext2ed: fix potential NULL pointer dereference in dupstr() argv_parse: check return value of malloc in argv_pars Wu Guanghao (6): profile_create_node: set magic before strdup(name) to fix memory leak tdb_transaction_recover: fix memory leak zap_sector: fix memory leak ss_add_info_dir: fix memory leak and check whether NULL pointer ss_create_invocation: fix memory leak and check whether NULL pointer append_pathname: append_pathname: check the value returned by realloc to avoid segfault contrib/android/base_fs.c | 12 +++++++++--- contrib/fsstress.c | 10 ++++++++-- ext2ed/main.c | 2 ++ lib/ext2fs/fileio.c | 11 +++++++++-- lib/ext2fs/hashmap.c | 12 ++++++++++-- lib/ext2fs/hashmap.h | 4 ++-- lib/ext2fs/tdb.c | 1 + lib/ss/error.c | 2 ++ lib/ss/help.c | 5 +++++ lib/ss/invocation.c | 38 ++++++++++++++++++++++++++++++++------ lib/support/argv_parse.c | 2 ++ lib/support/profile.c | 3 ++- misc/create_inode.c | 3 +++ misc/lsattr.c | 6 ++++++ misc/mke2fs.c | 1 + 15 files changed, 94 insertions(+), 18 deletions(-)