[SMB3,client] add trace event for mknod

Message ID	CAH2r5mu0HtRs_5hmKFLoh+OhWsHroAAHwvH51chaPJWWmpGPSg@mail.gmail.com
State	New
Headers	show Return-Path: <linux-cifs+bounces-1548-incoming=patchwork.ozlabs.org@vger.kernel.org> Precedence: bulk MIME-Version: 1.0 From: Steve French <smfrench@gmail.com> Date: Sun, 24 Mar 2024 00:06:49 -0500 Message-ID: <CAH2r5mu0HtRs_5hmKFLoh+OhWsHroAAHwvH51chaPJWWmpGPSg@mail.gmail.com> Subject: [PATCH][SMB3 client] add trace event for mknod To: CIFS <linux-cifs@vger.kernel.org> Cc: samba-technical <samba-technical@lists.samba.org>, Paulo Alcantara <pc@manguebit.com> Content-Type: multipart/mixed; boundary="000000000000e3fe3f06146106ee"
Series	[SMB3,client] add trace event for mknod \| expand [SMB3,client] add trace event for mknod

Message ID

CAH2r5mu0HtRs_5hmKFLoh+OhWsHroAAHwvH51chaPJWWmpGPSg@mail.gmail.com

State

New

Headers

Precedence: bulk
MIME-Version: 1.0
From: Steve French <smfrench@gmail.com>
Date: Sun, 24 Mar 2024 00:06:49 -0500
Message-ID: 
 <CAH2r5mu0HtRs_5hmKFLoh+OhWsHroAAHwvH51chaPJWWmpGPSg@mail.gmail.com>
Subject: [PATCH][SMB3 client] add trace event for mknod
To: CIFS <linux-cifs@vger.kernel.org>
Cc: samba-technical <samba-technical@lists.samba.org>,
 Paulo Alcantara <pc@manguebit.com>
Content-Type: multipart/mixed; boundary="000000000000e3fe3f06146106ee"

Series

[SMB3,client] add trace event for mknod | expand

Commit Message

Steve French March 24, 2024, 5:06 a.m. UTC

See attached

Add trace points to help debug mknod and mkfifo:

   smb3_mknod_done
   smb3_mknod_enter
   smb3_mknod_err

Example output:

      TASK-PID     CPU#  |||||  TIMESTAMP  FUNCTION
         | |         |   |||||     |         |
    mkfifo-6163    [003] .....   960.425558: smb3_mknod_enter: xid=12
sid=0xb55130f6 tid=0x46e6241c path=\fifo1
    mkfifo-6163    [003] .....   960.432719: smb3_mknod_done: xid=12
sid=0xb55130f6 tid=0x46e6241c

Comments

Meetakshi Setiya March 26, 2024, 4:01 p.m. UTC | #1

Looks good

On Sun, Mar 24, 2024 at 10:37 AM Steve French <smfrench@gmail.com> wrote:
>
> See attached
>
> Add trace points to help debug mknod and mkfifo:
>
>    smb3_mknod_done
>    smb3_mknod_enter
>    smb3_mknod_err
>
> Example output:
>
>       TASK-PID     CPU#  |||||  TIMESTAMP  FUNCTION
>          | |         |   |||||     |         |
>     mkfifo-6163    [003] .....   960.425558: smb3_mknod_enter: xid=12
> sid=0xb55130f6 tid=0x46e6241c path=\fifo1
>     mkfifo-6163    [003] .....   960.432719: smb3_mknod_done: xid=12
> sid=0xb55130f6 tid=0x46e6241c
>
>
> --
> Thanks,
>
> Steve

From bda0b06c0263d4d42989124826751d9e7fa82978 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Sun, 24 Mar 2024 00:01:02 -0500
Subject: [PATCH] smb3: add trace event for mknod

Add trace points to help debug mknod and mkfifo:

   smb3_mknod_done
   smb3_mknod_enter
   smb3_mknod_err

Example output:

      TASK-PID     CPU#  |||||  TIMESTAMP  FUNCTION
         | |         |   |||||     |         |
    mkfifo-6163    [003] .....   960.425558: smb3_mknod_enter: xid=12 sid=0xb55130f6 tid=0x46e6241c path=\fifo1
    mkfifo-6163    [003] .....   960.432719: smb3_mknod_done: xid=12 sid=0xb55130f6 tid=0x46e6241c

Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/smb/client/dir.c   | 7 +++++++
 fs/smb/client/trace.h | 4 +++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/fs/smb/client/dir.c b/fs/smb/client/dir.c
index 89333d9bce36..d11dc3aa458b 100644
--- a/fs/smb/client/dir.c
+++ b/fs/smb/client/dir.c
@@ -612,11 +612,18 @@  int cifs_mknod(struct mnt_idmap *idmap, struct inode *inode,
 		goto mknod_out;
 	}
 
+	trace_smb3_mknod_enter(xid, tcon->ses->Suid, tcon->tid, full_path);
+
 	rc = tcon->ses->server->ops->make_node(xid, inode, direntry, tcon,
 					       full_path, mode,
 					       device_number);
 
 mknod_out:
+	if (rc)
+		trace_smb3_mknod_err(xid,  tcon->ses->Suid, tcon->tid, rc);
+	else
+		trace_smb3_mknod_done(xid, tcon->ses->Suid, tcon->tid);
+
 	free_dentry_path(page);
 	free_xid(xid);
 	cifs_put_tlink(tlink);
diff --git a/fs/smb/client/trace.h b/fs/smb/client/trace.h
index f9c1fd32d0b8..5e83cb9da902 100644
--- a/fs/smb/client/trace.h
+++ b/fs/smb/client/trace.h
@@ -375,6 +375,7 @@  DEFINE_SMB3_INF_COMPOUND_ENTER_EVENT(get_reparse_compound_enter);
 DEFINE_SMB3_INF_COMPOUND_ENTER_EVENT(delete_enter);
 DEFINE_SMB3_INF_COMPOUND_ENTER_EVENT(mkdir_enter);
 DEFINE_SMB3_INF_COMPOUND_ENTER_EVENT(tdis_enter);
+DEFINE_SMB3_INF_COMPOUND_ENTER_EVENT(mknod_enter);
 
 DECLARE_EVENT_CLASS(smb3_inf_compound_done_class,
 	TP_PROTO(unsigned int xid,
@@ -415,7 +416,7 @@  DEFINE_SMB3_INF_COMPOUND_DONE_EVENT(query_wsl_ea_compound_done);
 DEFINE_SMB3_INF_COMPOUND_DONE_EVENT(delete_done);
 DEFINE_SMB3_INF_COMPOUND_DONE_EVENT(mkdir_done);
 DEFINE_SMB3_INF_COMPOUND_DONE_EVENT(tdis_done);
-
+DEFINE_SMB3_INF_COMPOUND_DONE_EVENT(mknod_done);
 
 DECLARE_EVENT_CLASS(smb3_inf_compound_err_class,
 	TP_PROTO(unsigned int xid,
@@ -461,6 +462,7 @@  DEFINE_SMB3_INF_COMPOUND_ERR_EVENT(query_wsl_ea_compound_err);
 DEFINE_SMB3_INF_COMPOUND_ERR_EVENT(mkdir_err);
 DEFINE_SMB3_INF_COMPOUND_ERR_EVENT(delete_err);
 DEFINE_SMB3_INF_COMPOUND_ERR_EVENT(tdis_err);
+DEFINE_SMB3_INF_COMPOUND_ERR_EVENT(mknod_err);
 
 /*
  * For logging SMB3 Status code and Command for responses which return errors
-- 
2.40.1

[SMB3,client] add trace event for mknod

Commit Message

Comments

Patch