diff mbox series

patch to removing minor DFS compile warnings

Message ID CAH2r5mtcGWchWxk8S7MCJa6zsuJZy6bxuwX7SeGm5K7MTT59cw@mail.gmail.com
State New
Headers show
Series patch to removing minor DFS compile warnings | expand

Commit Message

Steve French Nov. 10, 2021, 9:14 a.m. UTC 
CHECK   /home/smfrench/cifs-2.6/fs/cifs/connect.c
/home/smfrench/cifs-2.6/fs/cifs/connect.c:4137:5: warning: symbol
'__tree_connect_dfs_target' was not declared. Should it be static?
/home/smfrench/cifs-2.6/fs/cifs/connect.c:4236:5: warning: symbol
'tree_connect_dfs_target' was not declared. Should it be static?


--
Thanks,

Steve

Comments

Paulo Alcantara Nov. 10, 2021, 10:18 a.m. UTC | #1 
On November 10, 2021 6:14:24 AM GMT-03:00, Steve French <smfrench@gmail.com> wrote:
>  CHECK   /home/smfrench/cifs-2.6/fs/cifs/connect.c
>/home/smfrench/cifs-2.6/fs/cifs/connect.c:4137:5: warning: symbol
>'__tree_connect_dfs_target' was not declared. Should it be static?
>/home/smfrench/cifs-2.6/fs/cifs/connect.c:4236:5: warning: symbol
>'tree_connect_dfs_target' was not declared. Should it be static?
>
>
>--
>Thanks,
>
>Steve

looks good.  thx.
diff mbox series

Patch

From c14a9424dc360a9125cb4e7558bafe9426bc05f1 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Wed, 10 Nov 2021 03:09:52 -0600
Subject: [PATCH] smb3: remove trivial dfs compile warning

Fix warning caused by recent changes to the dfs code:

symbol 'tree_connect_dfs_target' was not declared. Should it be static?

Cc: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/connect.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index c07d5915b9b0..f645f994a523 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -4134,7 +4134,7 @@  static int target_share_matches_server(struct TCP_Server_Info *server, const cha
 	return rc;
 }
 
-int __tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tcon,
+static int __tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tcon,
 			      struct cifs_sb_info *cifs_sb, char *tree,
 			      struct dfs_cache_tgt_list *tl, struct dfs_info3_param *ref)
 {
@@ -4233,7 +4233,7 @@  int __tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tcon,
 	return rc;
 }
 
-int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tcon,
+static int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tcon,
 			    struct cifs_sb_info *cifs_sb, char *tree,
 			    struct dfs_cache_tgt_list *tl, struct dfs_info3_param *ref)
 {
-- 
2.32.0