From patchwork Wed Oct 24 02:14:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 988461 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="q/GGDIsh"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42fvl926HKz9s9h for ; Wed, 24 Oct 2018 13:45:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726371AbeJXLL4 (ORCPT ); Wed, 24 Oct 2018 07:11:56 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:42536 "EHLO mail-pg1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725826AbeJXLLz (ORCPT ); Wed, 24 Oct 2018 07:11:55 -0400 Received: by mail-pg1-f172.google.com with SMTP id i4-v6so1586804pgq.9 for ; Tue, 23 Oct 2018 19:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=m9qHMpiDsyqmeZCZQG6UZuUzF2kO2KFtDSTDvn0WbGg=; b=q/GGDIsh3kQwMFAblWjEXUd/+ipvbr9lUnmmGUCN52sKkWxkBpB5QhFU7kOTwD0vpG 74TK9+mgwjQ6Yjv6QA6q3F76WUXRjEzOkJK/4aBZHxCmk4A9nbBbl9/wExRTU0hHnWJM oTj9odT2N14jH9LlQe4TD1ESobUx9/5U9WYn8xMHKo6qxuSqMiR0hihlGAWJKM3lXW1j etMqiuYomlMjTV9L2fKo4yu5syxPvLfqW/D/MNPuf9ae0glCnJuF1vYdD5J57rsDuxXz XhGWg/gnZZj8P6rxMYoa0Ef6N6+DO8sQ84HKmSdDKMQf16oX9/wz8wKFnXZq0f/1rcEZ U9tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=m9qHMpiDsyqmeZCZQG6UZuUzF2kO2KFtDSTDvn0WbGg=; b=pFuyYaEHjahCpKLRQenvYg5IVy81kKleHCT2X/jx2jaPF6081zVzoNIXNxr6SqME3l we/KsxVNLE/ScS4F7OUiA1iMfq0elWXHK2eyzzLX3GNSdsLhDjDZfPYj2uWBQQ6hauYc bc038TrMARH36X4xg4e20847DLyGXHB838GPBOaiDakmIa9n8ZG7REuXAVkU500pbR1z +1LVY0EOlduaP3BDqjWeVkZ819/iOWIrRYPdUBFPaW60tc8jZwUQMsPW0fYfadVvkxEj jr05qp6Mpzt4jXL97WW3vbuc/e130iH44HtTGJUyI3Sq8TtILMKpDZiUFjukxuUsQnpa Z1Hw== X-Gm-Message-State: AGRZ1gKvBL4oezgH6B3cgtTNkAmbBARlKcI8kLaZHGS2bsFznHK5iwVm KXX9UfmK0eCX/YGDunf/QLrttgGSmMo0oPPDvv6JVY+N X-Google-Smtp-Source: AJdET5cbt9KEGsnhlheU4IHSUybxfJW4Wly7+5rsRjETl8tdm3ihelneHp8dhBguFB+rxo8ssnM26J7TIT126zVnuRU= X-Received: by 2002:a63:82c6:: with SMTP id w189mr748832pgd.344.1540347287577; Tue, 23 Oct 2018 19:14:47 -0700 (PDT) MIME-Version: 1.0 From: Steve French Date: Tue, 23 Oct 2018 21:14:34 -0500 Message-ID: Subject: Noisier debugging of unexpected mid cancellation To: CIFS Cc: ronnie sahlberg Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Have been trying to debug xfstest 28 warnings (unexpected cancellation of mid "CIFS VFS: Close unmatched open") so wanted to make this earlier (FYI level) message noisier and add which command is causing it (in this case open) From d9d6a30f0baa36859703c67b29aba9c259db1c0f Mon Sep 17 00:00:00 2001 From: Steve French Date: Tue, 23 Oct 2018 21:04:57 -0500 Subject: [PATCH 2/2] smb3: add debug for unexpected mid cancellation We have hit this intermittently, increase the verbosity of warning message on unexpected mid cancellation. Signed-off-by: Steve French --- fs/cifs/transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index fd80749c7838..f8112433f0c8 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -876,8 +876,8 @@ compound_send_recv(const unsigned int xid, struct cifs_ses *ses, for (i = 0; i < num_rqst; i++) { rc = wait_for_response(ses->server, midQ[i]); if (rc != 0) { - cifs_dbg(FYI, "Cancelling wait for mid %llu\n", - midQ[i]->mid); + cifs_dbg(VFS, "Cancelling wait for mid %llu cmd: %d\n", + midQ[i]->mid, le16_to_cpu(midQ[i]->command)); send_cancel(ses->server, &rqst[i], midQ[i]); spin_lock(&GlobalMid_Lock); if (midQ[i]->mid_state == MID_REQUEST_SUBMITTED) { -- 2.17.1