diff mbox series

[ksmbd] fix UAF in ksmbd_alloc_work_struct

Message ID CACp1nnB_nXtxAxNzoDqcDg=FTzQbxt14SFSTqN8tAE4fn_AQyw@mail.gmail.com
State New
Headers show
Series [ksmbd] fix UAF in ksmbd_alloc_work_struct | expand

Commit Message

Nathan French Aug. 21, 2023, 2:43 a.m. UTC 
avoid oops accessing null work struct pointer

    Fixes: bdf1b0e2a1ea ("ksmbd_alloc_work_struct")
    Addresses-Coverity: 1566875 ("Explicit null dereference")
    Reviewed-by: Jackson Winslow <jackwinslow35@gmail.com>
    Signed-off-by: Nathan French <nathanmfrench17@gmail.com>
diff mbox series

Patch

diff --git a/fs/smb/server/ksmbd_work.c b/fs/smb/server/ksmbd_work.c
index 51def3ca74c0..9411f7e32a3c 100644
--- a/fs/smb/server/ksmbd_work.c
+++ b/fs/smb/server/ksmbd_work.c
@@ -33,7 +33,7 @@  struct ksmbd_work *ksmbd_alloc_work_struct(void)
                                    GFP_KERNEL);
                if (!work->iov) {
                        kmem_cache_free(work_cache, work);
-                       work = NULL;
+                       return NULL;
                }
        }
        return work;