[1/5] cifs: avoid redundant calls to disable multichannel

Message ID	20240201111530.17194-1-sprasad@microsoft.com
State	New
Headers	show Return-Path: <linux-cifs+bounces-1080-incoming=patchwork.ozlabs.org@vger.kernel.org> From: nspmangalore@gmail.com To: linux-cifs@vger.kernel.org, smfrench@gmail.com, pc@manguebit.com, bharathsm@microsoft.com Cc: Shyam Prasad N <sprasad@microsoft.com> Subject: [PATCH 1/5] cifs: avoid redundant calls to disable multichannel Date: Thu, 1 Feb 2024 11:15:26 +0000 Message-Id: <20240201111530.17194-1-sprasad@microsoft.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	[1/5] cifs: avoid redundant calls to disable multichannel \| expand [1/5] cifs: avoid redundant calls to disable multichannel [2/5] cifs: change tcon status when need_reconnect is set on it [3/5] cifs: do not search for channel if server is terminating [4/5] cifs: failure to add channel on iface should bump up weight [5/5] cifs: enforce nosharesock when multichannel is used

Message ID

20240201111530.17194-1-sprasad@microsoft.com

State

New

Headers

From: nspmangalore@gmail.com
To: linux-cifs@vger.kernel.org,
	smfrench@gmail.com,
	pc@manguebit.com,
	bharathsm@microsoft.com
Cc: Shyam Prasad N <sprasad@microsoft.com>
Subject: [PATCH 1/5] cifs: avoid redundant calls to disable multichannel
Date: Thu,  1 Feb 2024 11:15:26 +0000
Message-Id: <20240201111530.17194-1-sprasad@microsoft.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

[1/5] cifs: avoid redundant calls to disable multichannel | expand

Commit Message

Shyam Prasad N Feb. 1, 2024, 11:15 a.m. UTC

From: Shyam Prasad N <sprasad@microsoft.com>

When the server reports query network interface info call
as unsupported following a tree connect, it means that
multichannel is unsupported, even if the server capabilities
report otherwise.

When this happens, cifs_chan_skip_or_disable is called to
disable multichannel on the client. However, we only need
to call this when multichannel is currently setup.

Fixes: f591062bdbf4 ("cifs: handle servers that still advertise multichannel after disabling")
Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
---
 fs/smb/client/smb2pdu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c
index 3110aabc32c5..75713559e69f 100644
--- a/fs/smb/client/smb2pdu.c
+++ b/fs/smb/client/smb2pdu.c
@@ -419,7 +419,7 @@  smb2_reconnect(__le16 smb2_command, struct cifs_tcon *tcon,
 		rc = SMB3_request_interfaces(xid, tcon, false);
 		free_xid(xid);
 
-		if (rc == -EOPNOTSUPP) {
+		if (rc == -EOPNOTSUPP && ses->chan_count > 1) {
 			/*
 			 * some servers like Azure SMB server do not advertise
 			 * that multichannel has been disabled with server

[1/5] cifs: avoid redundant calls to disable multichannel

Commit Message

Patch