| Message ID | 20220628213229.354032-1-colin.i.king@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | cifs: remove redundant initialization to variable mnt_sign_enabled | expand |
merged into cifs-2.6.git for-next On Tue, Jun 28, 2022 at 4:40 PM Colin Ian King <colin.i.king@gmail.com> wrote: > > Variable mnt_sign_enabled is being initialized with a value that > is never read, it is being reassigned later on with a different > value. The initialization is redundant and can be removed. > > Cleans up clang scan-build warning: > fs/cifs/cifssmb.c:465:7: warning: Value stored to 'mnt_sign_enabled > during its initialization is never read > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > fs/cifs/cifssmb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c > index 6371b9eebdad..9ed21752f2df 100644 > --- a/fs/cifs/cifssmb.c > +++ b/fs/cifs/cifssmb.c > @@ -462,7 +462,7 @@ cifs_enable_signing(struct TCP_Server_Info *server, bool mnt_sign_required) > { > bool srv_sign_required = server->sec_mode & server->vals->signing_required; > bool srv_sign_enabled = server->sec_mode & server->vals->signing_enabled; > - bool mnt_sign_enabled = global_secflags & CIFSSEC_MAY_SIGN; > + bool mnt_sign_enabled; > > /* > * Is signing required by mnt options? If not then check > -- > 2.35.3 >
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 6371b9eebdad..9ed21752f2df 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -462,7 +462,7 @@ cifs_enable_signing(struct TCP_Server_Info *server, bool mnt_sign_required) { bool srv_sign_required = server->sec_mode & server->vals->signing_required; bool srv_sign_enabled = server->sec_mode & server->vals->signing_enabled; - bool mnt_sign_enabled = global_secflags & CIFSSEC_MAY_SIGN; + bool mnt_sign_enabled; /* * Is signing required by mnt options? If not then check
Variable mnt_sign_enabled is being initialized with a value that is never read, it is being reassigned later on with a different value. The initialization is redundant and can be removed. Cleans up clang scan-build warning: fs/cifs/cifssmb.c:465:7: warning: Value stored to 'mnt_sign_enabled during its initialization is never read Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- fs/cifs/cifssmb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)